summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJaikumar Ganesh <jaikumar@google.com>2011-07-13 12:29:57 -0700
committerJaikumar Ganesh <jaikumar@google.com>2011-07-13 12:29:57 -0700
commit6dd4531639157191e6224d3f8af5c9d099ca945f (patch)
tree4d1ec866d2330c7d20216cc36c90076a3c68900b
parent28d92afc0a17cbf9149a0c8be9c8795d6f3306a5 (diff)
parentab3ec17608fd17b48ae3a4b7359f5a150da3cf7e (diff)
downloadframeworks_base-6dd4531639157191e6224d3f8af5c9d099ca945f.zip
frameworks_base-6dd4531639157191e6224d3f8af5c9d099ca945f.tar.gz
frameworks_base-6dd4531639157191e6224d3f8af5c9d099ca945f.tar.bz2
resolved conflicts for merge of ab3ec176 to honeycomb-plus-aosp
Change-Id: I75fcd15f85f2cb3912ada1df453fb02bd13e5d85
-rw-r--r--core/java/android/bluetooth/BluetoothAdapter.java2
-rw-r--r--core/jni/android_server_BluetoothService.cpp11
-rw-r--r--core/tests/coretests/src/android/bluetooth/BluetoothTestUtils.java3
3 files changed, 10 insertions, 6 deletions
diff --git a/core/java/android/bluetooth/BluetoothAdapter.java b/core/java/android/bluetooth/BluetoothAdapter.java
index 88e00b3..a8c31f9 100644
--- a/core/java/android/bluetooth/BluetoothAdapter.java
+++ b/core/java/android/bluetooth/BluetoothAdapter.java
@@ -699,7 +699,7 @@ public final class BluetoothAdapter {
public boolean cancelDiscovery() {
if (getState() != STATE_ON) return false;
try {
- mService.cancelDiscovery();
+ return mService.cancelDiscovery();
} catch (RemoteException e) {Log.e(TAG, "", e);}
return false;
}
diff --git a/core/jni/android_server_BluetoothService.cpp b/core/jni/android_server_BluetoothService.cpp
index 158e475..6b7931c 100644
--- a/core/jni/android_server_BluetoothService.cpp
+++ b/core/jni/android_server_BluetoothService.cpp
@@ -250,15 +250,15 @@ done:
#endif
}
-static void stopDiscoveryNative(JNIEnv *env, jobject object) {
- LOGV("%s", __FUNCTION__);
+static jboolean stopDiscoveryNative(JNIEnv *env, jobject object) {
+ LOGV(__FUNCTION__);
#ifdef HAVE_BLUETOOTH
DBusMessage *msg = NULL;
DBusMessage *reply = NULL;
DBusError err;
const char *name;
- jstring ret;
native_data_t *nat;
+ jboolean ret = JNI_FALSE;
dbus_error_init(&err);
@@ -288,11 +288,16 @@ static void stopDiscoveryNative(JNIEnv *env, jobject object) {
} else {
LOG_AND_FREE_DBUS_ERROR_WITH_MSG(&err, msg);
}
+ goto done;
}
+ ret = JNI_TRUE;
done:
if (msg) dbus_message_unref(msg);
if (reply) dbus_message_unref(reply);
+ return ret;
+#else
+ return JNI_FALSE;
#endif
}
diff --git a/core/tests/coretests/src/android/bluetooth/BluetoothTestUtils.java b/core/tests/coretests/src/android/bluetooth/BluetoothTestUtils.java
index f1dd8fe..5f4c226 100644
--- a/core/tests/coretests/src/android/bluetooth/BluetoothTestUtils.java
+++ b/core/tests/coretests/src/android/bluetooth/BluetoothTestUtils.java
@@ -678,8 +678,7 @@ public class BluetoothTestUtils extends Assert {
BluetoothReceiver receiver = getBluetoothReceiver(mask);
long start = System.currentTimeMillis();
- // TODO: put assertTrue() around cancelDiscovery() once it starts returning true.
- adapter.cancelDiscovery();
+ assertTrue(adapter.cancelDiscovery());
while (System.currentTimeMillis() - start < START_STOP_SCAN_TIMEOUT) {
if (!adapter.isDiscovering() && ((receiver.getFiredFlags() & mask) == mask)) {