summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLeon Scroggins III <scroggo@google.com>2015-06-02 12:59:29 +0000
committerAndroid Git Automerger <android-git-automerger@android.com>2015-06-02 12:59:29 +0000
commit7496e153f4308b39df9c53615770f44f593c3504 (patch)
tree4c9cd3d4eac05c6507d4a818888a3e585011173a
parent11297581667128d2568a47ee03acab5c4f9f2784 (diff)
parent0d2081734ce124191ac1f3e8585336daa414abbe (diff)
downloadframeworks_base-7496e153f4308b39df9c53615770f44f593c3504.zip
frameworks_base-7496e153f4308b39df9c53615770f44f593c3504.tar.gz
frameworks_base-7496e153f4308b39df9c53615770f44f593c3504.tar.bz2
am 0d208173: DO NOT MERGE: Ensure that unparcelling Region only reads the expected number of bytes
* commit '0d2081734ce124191ac1f3e8585336daa414abbe': DO NOT MERGE: Ensure that unparcelling Region only reads the expected number of bytes
-rw-r--r--core/jni/android/graphics/Region.cpp7
1 files changed, 6 insertions, 1 deletions
diff --git a/core/jni/android/graphics/Region.cpp b/core/jni/android/graphics/Region.cpp
index 1e0cf96..d901e9c 100644
--- a/core/jni/android/graphics/Region.cpp
+++ b/core/jni/android/graphics/Region.cpp
@@ -181,7 +181,12 @@ static SkRegion* Region_createFromParcel(JNIEnv* env, jobject clazz, jobject par
return NULL;
}
SkRegion* region = new SkRegion;
- region->readFromMemory(regionData, size);
+ size_t actualSize = region->readFromMemory(regionData, size);
+
+ if (size != actualSize) {
+ delete region;
+ return NULL;
+ }
return region;
}