summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSeigo Nonaka <nona@google.com>2015-04-10 04:35:36 +0000
committerAndroid (Google) Code Review <android-gerrit@google.com>2015-04-10 04:35:38 +0000
commit7bfcad34274e7d78a85cc7f54bb64d3e5ffa7da6 (patch)
treeed582b39ac9eb8225482822f3c24aabf1262d22c
parent7f9be1cbfaafe9f92f3c073a7b48bbfaa12230ba (diff)
parentbb6a62c2be16bf99b2e8b9a4aa15b8dc267ad3fc (diff)
downloadframeworks_base-7bfcad34274e7d78a85cc7f54bb64d3e5ffa7da6.zip
frameworks_base-7bfcad34274e7d78a85cc7f54bb64d3e5ffa7da6.tar.gz
frameworks_base-7bfcad34274e7d78a85cc7f54bb64d3e5ffa7da6.tar.bz2
Merge "Fix unexpected selection cancellation"
-rw-r--r--core/java/android/widget/Editor.java2
-rw-r--r--core/java/android/widget/TextView.java6
2 files changed, 7 insertions, 1 deletions
diff --git a/core/java/android/widget/Editor.java b/core/java/android/widget/Editor.java
index 8f4e8e1..0199f6d 100644
--- a/core/java/android/widget/Editor.java
+++ b/core/java/android/widget/Editor.java
@@ -557,7 +557,7 @@ public class Editor {
}
}
- private void hideInsertionPointCursorController() {
+ void hideInsertionPointCursorController() {
if (mInsertionPointCursorController != null) {
mInsertionPointCursorController.hide();
}
diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java
index 9caa584..11439e4 100644
--- a/core/java/android/widget/TextView.java
+++ b/core/java/android/widget/TextView.java
@@ -9067,6 +9067,12 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
}
boolean selectAllText() {
+ // Need to hide insert point cursor controller before settings selection, otherwise insert
+ // point cursor controller obtains cursor update event and update cursor with cancelling
+ // selection.
+ if (mEditor != null) {
+ mEditor.hideInsertionPointCursorController();
+ }
final int length = mText.length();
Selection.setSelection((Spannable) mText, 0, length);
return length > 0;