diff options
| author | Android (Google) Code Review <android-gerrit@google.com> | 2009-07-09 15:45:22 -0700 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2009-07-09 15:45:22 -0700 |
| commit | 8440ecce813112493d2af4097608735c4c7a870c (patch) | |
| tree | 69bacab009f68c7a16b88051a78b13c3ba19c2e8 | |
| parent | 8f7c7c0c18987b1045cb73e503f82ce429a0d924 (diff) | |
| parent | f4422ce8293bdb4b6d9f091d38ab588d0bb2e4e4 (diff) | |
| download | frameworks_base-8440ecce813112493d2af4097608735c4c7a870c.zip frameworks_base-8440ecce813112493d2af4097608735c4c7a870c.tar.gz frameworks_base-8440ecce813112493d2af4097608735c4c7a870c.tar.bz2 | |
Merge change 6668 into donut
* changes:
Check if a searchable is null before adding it to the list of searchables for web search. If getActivityMetaData returned null for a web search searchable, previously, this null would get added to the list of searchables for web search, which was causing GlobalSearch's SearchSettings to crash with an NPE (which I've guarded against in change 6602).
| -rw-r--r-- | core/java/android/server/search/Searchables.java | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/core/java/android/server/search/Searchables.java b/core/java/android/server/search/Searchables.java index b959907..c615957 100644 --- a/core/java/android/server/search/Searchables.java +++ b/core/java/android/server/search/Searchables.java @@ -247,7 +247,12 @@ public class Searchables { for (int i = 0; i < webSearchInfoList.size(); ++i) { ActivityInfo ai = webSearchInfoList.get(i).activityInfo; ComponentName component = new ComponentName(ai.packageName, ai.name); - newSearchablesForWebSearchList.add(newSearchablesMap.get(component)); + SearchableInfo searchable = newSearchablesMap.get(component); + if (searchable == null) { + Log.w(LOG_TAG, "did not find component in searchables: " + component); + } else { + newSearchablesForWebSearchList.add(searchable); + } } } |
