summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Bestas <mikeioannina@cyanogenmod.org>2016-01-25 13:24:10 +0200
committerSteve Kondik <shade@chemlab.org>2016-02-20 08:33:28 -0800
commit87a2f454625e922969103a7dc0ef6fa5b33ac02f (patch)
tree6951107fa844b2a4ea6cfb7c184ca678e5f20c37
parent862c4e2b5b6183b2732ad3af329db848b25bfbeb (diff)
downloadframeworks_base-87a2f454625e922969103a7dc0ef6fa5b33ac02f.zip
frameworks_base-87a2f454625e922969103a7dc0ef6fa5b33ac02f.tar.gz
frameworks_base-87a2f454625e922969103a7dc0ef6fa5b33ac02f.tar.bz2
aapt: Hide "No comment for public symbol" warnings
* Hide these warnings by default behind the kIsDebug flag Change-Id: I56270c5e34bb05a88500eea83879790ad43a814c
-rw-r--r--tools/aapt/Resource.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/aapt/Resource.cpp b/tools/aapt/Resource.cpp
index c636c28..b796b27 100644
--- a/tools/aapt/Resource.cpp
+++ b/tools/aapt/Resource.cpp
@@ -2543,7 +2543,7 @@ static status_t writeSymbolClass(
fprintf(fp,
"%s/** %s\n",
getIndentSpace(indent), cmt.string());
- } else if (sym.isPublic && !includePrivate) {
+ } else if (sym.isPublic && !includePrivate && kIsDebug) {
sym.sourcePos.warning("No comment for public symbol %s:%s/%s",
assets->getPackage().string(), className.string(),
String8(sym.name).string());
@@ -2589,7 +2589,7 @@ static status_t writeSymbolClass(
"%s */\n",
getIndentSpace(indent), cmt.string(),
getIndentSpace(indent));
- } else if (sym.isPublic && !includePrivate) {
+ } else if (sym.isPublic && !includePrivate && kIsDebug) {
sym.sourcePos.warning("No comment for public symbol %s:%s/%s",
assets->getPackage().string(), className.string(),
String8(sym.name).string());