diff options
| author | Jeff Sharkey <jsharkey@android.com> | 2014-10-15 16:49:04 +0000 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2014-10-15 16:49:05 +0000 |
| commit | 88a6ed5477eb6fa0453f9f29adef4c11b6eeade0 (patch) | |
| tree | 2dd2864b7711b93d7e1c1c2d7480d165dc261ab5 | |
| parent | 8e0297155075f9772dd6e8b8194da074dca008f8 (diff) | |
| parent | 97d47ed036ff7bd3d7d2ddc1c6df1104ec237559 (diff) | |
| download | frameworks_base-88a6ed5477eb6fa0453f9f29adef4c11b6eeade0.zip frameworks_base-88a6ed5477eb6fa0453f9f29adef4c11b6eeade0.tar.gz frameworks_base-88a6ed5477eb6fa0453f9f29adef4c11b6eeade0.tar.bz2 | |
Merge "Reduce PackageInstaller Binder memory pressure." into lmp-dev
3 files changed, 10 insertions, 8 deletions
diff --git a/core/java/android/content/pm/IPackageInstaller.aidl b/core/java/android/content/pm/IPackageInstaller.aidl index 6daefc8..ba62cd6 100644 --- a/core/java/android/content/pm/IPackageInstaller.aidl +++ b/core/java/android/content/pm/IPackageInstaller.aidl @@ -20,6 +20,7 @@ import android.content.pm.IPackageDeleteObserver2; import android.content.pm.IPackageInstallerCallback; import android.content.pm.IPackageInstallerSession; import android.content.pm.PackageInstaller; +import android.content.pm.ParceledListSlice; import android.content.IntentSender; import android.graphics.Bitmap; @@ -37,8 +38,8 @@ interface IPackageInstaller { PackageInstaller.SessionInfo getSessionInfo(int sessionId); - List<PackageInstaller.SessionInfo> getAllSessions(int userId); - List<PackageInstaller.SessionInfo> getMySessions(String installerPackageName, int userId); + ParceledListSlice getAllSessions(int userId); + ParceledListSlice getMySessions(String installerPackageName, int userId); void registerCallback(IPackageInstallerCallback callback, int userId); void unregisterCallback(IPackageInstallerCallback callback); diff --git a/core/java/android/content/pm/PackageInstaller.java b/core/java/android/content/pm/PackageInstaller.java index f249c5f..80efd0b 100644 --- a/core/java/android/content/pm/PackageInstaller.java +++ b/core/java/android/content/pm/PackageInstaller.java @@ -399,7 +399,7 @@ public class PackageInstaller { } try { - return mInstaller.getAllSessions(mUserId); + return mInstaller.getAllSessions(mUserId).getList(); } catch (RemoteException e) { throw e.rethrowAsRuntimeException(); } @@ -410,7 +410,7 @@ public class PackageInstaller { */ public @NonNull List<SessionInfo> getMySessions() { try { - return mInstaller.getMySessions(mInstallerPackageName, mUserId); + return mInstaller.getMySessions(mInstallerPackageName, mUserId).getList(); } catch (RemoteException e) { throw e.rethrowAsRuntimeException(); } diff --git a/services/core/java/com/android/server/pm/PackageInstallerService.java b/services/core/java/com/android/server/pm/PackageInstallerService.java index 9db3fba..2150e9a 100644 --- a/services/core/java/com/android/server/pm/PackageInstallerService.java +++ b/services/core/java/com/android/server/pm/PackageInstallerService.java @@ -45,6 +45,7 @@ import android.content.pm.PackageInstaller; import android.content.pm.PackageInstaller.SessionInfo; import android.content.pm.PackageInstaller.SessionParams; import android.content.pm.PackageManager; +import android.content.pm.ParceledListSlice; import android.graphics.Bitmap; import android.graphics.Bitmap.CompressFormat; import android.graphics.BitmapFactory; @@ -714,7 +715,7 @@ public class PackageInstallerService extends IPackageInstaller.Stub { } @Override - public List<SessionInfo> getAllSessions(int userId) { + public ParceledListSlice<SessionInfo> getAllSessions(int userId) { mPm.enforceCrossUserPermission(Binder.getCallingUid(), userId, true, false, "getAllSessions"); final List<SessionInfo> result = new ArrayList<>(); @@ -726,11 +727,11 @@ public class PackageInstallerService extends IPackageInstaller.Stub { } } } - return result; + return new ParceledListSlice<>(result); } @Override - public List<SessionInfo> getMySessions(String installerPackageName, int userId) { + public ParceledListSlice<SessionInfo> getMySessions(String installerPackageName, int userId) { mPm.enforceCrossUserPermission(Binder.getCallingUid(), userId, true, false, "getMySessions"); mAppOps.checkPackage(Binder.getCallingUid(), installerPackageName); @@ -744,7 +745,7 @@ public class PackageInstallerService extends IPackageInstaller.Stub { } } } - return result; + return new ParceledListSlice<>(result); } @Override |
