summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike J. Chen <mjchen@google.com>2013-05-01 14:02:32 -0700
committerAndroid Git Automerger <android-git-automerger@android.com>2013-05-01 14:02:32 -0700
commit94264d522efcc21ac749a6444fbea90916f575c9 (patch)
tree6a1f75af3f16fe87d9dfc4821de196bdac4724ba
parent2046a8f1572df95bbb46a47d96dab06666d743de (diff)
parent2f4cc8eacfe819a4f54aa4b0318ad1d31ecc2a40 (diff)
downloadframeworks_base-94264d522efcc21ac749a6444fbea90916f575c9.zip
frameworks_base-94264d522efcc21ac749a6444fbea90916f575c9.tar.gz
frameworks_base-94264d522efcc21ac749a6444fbea90916f575c9.tar.bz2
am 2f4cc8ea: Merge "Fix a crash case" into jb-mr2-dev
* commit '2f4cc8eacfe819a4f54aa4b0318ad1d31ecc2a40': Fix a crash case
-rw-r--r--media/jni/audioeffect/android_media_Visualizer.cpp11
1 files changed, 6 insertions, 5 deletions
diff --git a/media/jni/audioeffect/android_media_Visualizer.cpp b/media/jni/audioeffect/android_media_Visualizer.cpp
index c2655c7..4d77cfd 100644
--- a/media/jni/audioeffect/android_media_Visualizer.cpp
+++ b/media/jni/audioeffect/android_media_Visualizer.cpp
@@ -164,17 +164,18 @@ static void captureCallback(void* user,
visualizer_callback_cookie *callbackInfo = (visualizer_callback_cookie *)user;
JNIEnv *env = AndroidRuntime::getJNIEnv();
- AutoMutex lock(&callbackInfo->callback_data_lock);
+
+ if (!user || !env) {
+ ALOGW("captureCallback error user %p, env %p", user, env);
+ return;
+ }
ALOGV("captureCallback: callbackInfo %p, visualizer_ref %p visualizer_class %p",
callbackInfo,
callbackInfo->visualizer_ref,
callbackInfo->visualizer_class);
- if (!user || !env) {
- ALOGW("captureCallback error user %p, env %p", user, env);
- return;
- }
+ AutoMutex lock(&callbackInfo->callback_data_lock);
if (waveformSize != 0 && waveform != NULL) {
jbyteArray jArray;