summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJay Shrauner <shrauner@google.com>2013-10-21 11:54:19 -0700
committerJay Shrauner <shrauner@google.com>2013-10-21 11:57:20 -0700
commita2c93480e35ec06e44f4ccfa8657eacf3353be46 (patch)
treee587cdb5413d452faf0f889c7b73d25b365dcf7e
parentd570dae5775be9df8ee218ce617c50e8097e6dcc (diff)
downloadframeworks_base-a2c93480e35ec06e44f4ccfa8657eacf3353be46.zip
frameworks_base-a2c93480e35ec06e44f4ccfa8657eacf3353be46.tar.gz
frameworks_base-a2c93480e35ec06e44f4ccfa8657eacf3353be46.tar.bz2
Fix CountryDetector NPE
Fix CountryDetector NPE by calling CallerInfo.getCurrentCountryIso() which checks for potential nulls. Bug:11291034 Change-Id: I0a4412c432551c64ec30652d69636442653ee337
-rw-r--r--telephony/java/com/android/internal/telephony/CallerInfo.java4
-rw-r--r--telephony/java/com/android/internal/telephony/CallerInfoAsyncQuery.java5
2 files changed, 5 insertions, 4 deletions
diff --git a/telephony/java/com/android/internal/telephony/CallerInfo.java b/telephony/java/com/android/internal/telephony/CallerInfo.java
index e3c664b..f6143ed 100644
--- a/telephony/java/com/android/internal/telephony/CallerInfo.java
+++ b/telephony/java/com/android/internal/telephony/CallerInfo.java
@@ -581,6 +581,10 @@ public class CallerInfo {
return countryIso;
}
+ protected static String getCurrentCountryIso(Context context) {
+ return getCurrentCountryIso(context, Locale.getDefault());
+ }
+
/**
* @return a string debug representation of this instance.
*/
diff --git a/telephony/java/com/android/internal/telephony/CallerInfoAsyncQuery.java b/telephony/java/com/android/internal/telephony/CallerInfoAsyncQuery.java
index dd5f644..c63be91 100644
--- a/telephony/java/com/android/internal/telephony/CallerInfoAsyncQuery.java
+++ b/telephony/java/com/android/internal/telephony/CallerInfoAsyncQuery.java
@@ -20,7 +20,6 @@ import android.content.AsyncQueryHandler;
import android.content.Context;
import android.database.Cursor;
import android.database.SQLException;
-import android.location.CountryDetector;
import android.net.Uri;
import android.os.Handler;
import android.os.Looper;
@@ -271,11 +270,9 @@ public class CallerInfoAsyncQuery {
// Use the number entered by the user for display.
if (!TextUtils.isEmpty(cw.number)) {
- CountryDetector detector = (CountryDetector) mQueryContext.getSystemService(
- Context.COUNTRY_DETECTOR);
mCallerInfo.phoneNumber = PhoneNumberUtils.formatNumber(cw.number,
mCallerInfo.normalizedNumber,
- detector.detectCountry().getCountryIso());
+ CallerInfo.getCurrentCountryIso(mQueryContext));
}
}