summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDianne Hackborn <hackbod@google.com>2012-02-16 14:48:48 -0800
committerAndroid Git Automerger <android-git-automerger@android.com>2012-02-16 14:48:48 -0800
commita3b5f6c29b44d6409e44317c6469a119ba547608 (patch)
tree2933ccffbd2adab4444842b476127510cb7550f2
parent23677064730117feefff3d477ecf5f93baf28704 (diff)
parent804aa297950949985882e4841303cd6e12fae06e (diff)
downloadframeworks_base-a3b5f6c29b44d6409e44317c6469a119ba547608.zip
frameworks_base-a3b5f6c29b44d6409e44317c6469a119ba547608.tar.gz
frameworks_base-a3b5f6c29b44d6409e44317c6469a119ba547608.tar.bz2
am 804aa297: am 01810bbb: am 06a591cd: Fix last change -- don\'t call startInputInner() with lock held.
* commit '804aa297950949985882e4841303cd6e12fae06e': Fix last change -- don't call startInputInner() with lock held.
-rw-r--r--core/java/android/view/inputmethod/InputMethodManager.java13
1 files changed, 9 insertions, 4 deletions
diff --git a/core/java/android/view/inputmethod/InputMethodManager.java b/core/java/android/view/inputmethod/InputMethodManager.java
index f79ac93..b1d7a18 100644
--- a/core/java/android/view/inputmethod/InputMethodManager.java
+++ b/core/java/android/view/inputmethod/InputMethodManager.java
@@ -336,6 +336,7 @@ public final class InputMethodManager {
}
case MSG_UNBIND: {
final int sequence = msg.arg1;
+ boolean startInput = false;
synchronized (mH) {
if (mBindSequence == sequence) {
if (false) {
@@ -356,10 +357,13 @@ public final class InputMethodManager {
mServedConnecting = true;
}
if (mActive) {
- startInputInner();
+ startInput = true;
}
}
}
+ if (startInput) {
+ startInputInner();
+ }
return;
}
case MSG_SET_ACTIVE: {
@@ -1217,12 +1221,13 @@ public final class InputMethodManager {
mService.windowGainedFocus(mClient, rootView.getWindowToken(),
focusedView != null, isTextEditor, softInputMode, first,
windowFlags);
- if (startInput) {
- startInputInner();
- }
} catch (RemoteException e) {
}
}
+
+ if (startInput) {
+ startInputInner();
+ }
}
/** @hide */