diff options
author | Tyler Gunn <tgunn@google.com> | 2015-08-19 22:29:51 +0000 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2015-08-19 22:29:51 +0000 |
commit | a65626031017517331fd402541b5e8f072c46a34 (patch) | |
tree | 3eb824eae758fc383f3d6845fec80ee2f7fa933a | |
parent | 0257c82fa122243e97e4a1f4ef4bc4b8c21bd692 (diff) | |
parent | 1e9bfc6461d3fe5455c9d7a21414ec66695b5798 (diff) | |
download | frameworks_base-a65626031017517331fd402541b5e8f072c46a34.zip frameworks_base-a65626031017517331fd402541b5e8f072c46a34.tar.gz frameworks_base-a65626031017517331fd402541b5e8f072c46a34.tar.bz2 |
am 1e9bfc64: Fix incorrect android.telecom.Call.Details equality check.
* commit '1e9bfc6461d3fe5455c9d7a21414ec66695b5798':
Fix incorrect android.telecom.Call.Details equality check.
-rw-r--r-- | telecomm/java/android/telecom/Call.java | 32 |
1 files changed, 30 insertions, 2 deletions
diff --git a/telecomm/java/android/telecom/Call.java b/telecomm/java/android/telecom/Call.java index 49f738b..f149f24 100644 --- a/telecomm/java/android/telecom/Call.java +++ b/telecomm/java/android/telecom/Call.java @@ -512,8 +512,8 @@ public final class Call { Objects.equals(mGatewayInfo, d.mGatewayInfo) && Objects.equals(mVideoState, d.mVideoState) && Objects.equals(mStatusHints, d.mStatusHints) && - Objects.equals(mExtras, d.mExtras) && - Objects.equals(mIntentExtras, d.mIntentExtras); + areBundlesEqual(mExtras, d.mExtras) && + areBundlesEqual(mIntentExtras, d.mIntentExtras); } return false; } @@ -1252,4 +1252,32 @@ public final class Call { }); } } + + /** + * Determines if two bundles are equal. + * + * @param bundle The original bundle. + * @param newBundle The bundle to compare with. + * @retrun {@code true} if the bundles are equal, {@code false} otherwise. + */ + private static boolean areBundlesEqual(Bundle bundle, Bundle newBundle) { + if (bundle == null || newBundle == null) { + return bundle == newBundle; + } + + if (bundle.size() != newBundle.size()) { + return false; + } + + for(String key : bundle.keySet()) { + if (key != null) { + final Object value = bundle.get(key); + final Object newValue = newBundle.get(key); + if (!Objects.equals(value, newValue)) { + return false; + } + } + } + return true; + } } |