summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Hines <srhines@google.com>2012-11-05 20:58:41 -0800
committerStephen Hines <srhines@google.com>2012-11-05 20:58:41 -0800
commitbd5b3a7cb1696e153c945de2a95a4f7432458267 (patch)
tree058bc219873b26dfd54ca6b06dce7fc8930db266
parentb274ea641ba8fd6bf11db91103788a7cfaa48317 (diff)
downloadframeworks_base-bd5b3a7cb1696e153c945de2a95a4f7432458267.zip
frameworks_base-bd5b3a7cb1696e153c945de2a95a4f7432458267.tar.gz
frameworks_base-bd5b3a7cb1696e153c945de2a95a4f7432458267.tar.bz2
Minor fixes for range clamp + default blending.
We could use setHasAlpha(false) if we were targeting API 12+, but instead we need to settle for having the script do this explicitly. Change-Id: I1c8ebbddcba5a003c69fefa48ec1aaf7d0e6726c
-rw-r--r--tests/RenderScriptTests/ImageProcessing2/src/com/android/rs/image/convolve3x3.rs4
-rw-r--r--tests/RenderScriptTests/ImageProcessing2/src/com/android/rs/image/convolve5x5.rs1
2 files changed, 3 insertions, 2 deletions
diff --git a/tests/RenderScriptTests/ImageProcessing2/src/com/android/rs/image/convolve3x3.rs b/tests/RenderScriptTests/ImageProcessing2/src/com/android/rs/image/convolve3x3.rs
index b55190c..13f9032 100644
--- a/tests/RenderScriptTests/ImageProcessing2/src/com/android/rs/image/convolve3x3.rs
+++ b/tests/RenderScriptTests/ImageProcessing2/src/com/android/rs/image/convolve3x3.rs
@@ -25,9 +25,9 @@ rs_allocation gIn;
float gCoeffs[9];
void root(uchar4 *out, uint32_t x, uint32_t y) {
- uint32_t x1 = min((int32_t)x+1, gWidth);
+ uint32_t x1 = min((int32_t)x+1, gWidth-1);
uint32_t x2 = max((int32_t)x-1, 0);
- uint32_t y1 = min((int32_t)y+1, gHeight);
+ uint32_t y1 = min((int32_t)y+1, gHeight-1);
uint32_t y2 = max((int32_t)y-1, 0);
float4 p00 = convert_float4(((uchar4 *)rsGetElementAt(gIn, x1, y1))[0]);
diff --git a/tests/RenderScriptTests/ImageProcessing2/src/com/android/rs/image/convolve5x5.rs b/tests/RenderScriptTests/ImageProcessing2/src/com/android/rs/image/convolve5x5.rs
index b110b88..b1ad241 100644
--- a/tests/RenderScriptTests/ImageProcessing2/src/com/android/rs/image/convolve5x5.rs
+++ b/tests/RenderScriptTests/ImageProcessing2/src/com/android/rs/image/convolve5x5.rs
@@ -68,6 +68,7 @@ void root(uchar4 *out, uint32_t x, uint32_t y) {
+ convert_float4(rsGetElementAt_uchar4(gIn, x4, y4)) * gCoeffs[24];
p0 = clamp(p0 + p1 + p2 + p3 + p4, 0.f, 255.f);
+ p0.a = 255.f;
*out = convert_uchar4(p0);
}