diff options
author | Mathias Agopian <mathias@google.com> | 2009-09-14 15:48:42 -0700 |
---|---|---|
committer | Mathias Agopian <mathias@google.com> | 2009-09-14 15:48:42 -0700 |
commit | bd8527110caa5427ade0edd7ce0d00e63f15ccbc (patch) | |
tree | b3f278132e4c3e9b78cfdfa48a97bf84f26e5d98 | |
parent | df5e76f9c635a84efa16c5e2f6cf516b4b8fe300 (diff) | |
download | frameworks_base-bd8527110caa5427ade0edd7ce0d00e63f15ccbc.zip frameworks_base-bd8527110caa5427ade0edd7ce0d00e63f15ccbc.tar.gz frameworks_base-bd8527110caa5427ade0edd7ce0d00e63f15ccbc.tar.bz2 |
make sure to update the tail pointer when undoing a dequeue
-rw-r--r-- | include/private/ui/SharedBufferStack.h | 2 | ||||
-rw-r--r-- | libs/ui/SharedBufferStack.cpp | 20 |
2 files changed, 17 insertions, 5 deletions
diff --git a/include/private/ui/SharedBufferStack.h b/include/private/ui/SharedBufferStack.h index 6181f55..8b0f154 100644 --- a/include/private/ui/SharedBufferStack.h +++ b/include/private/ui/SharedBufferStack.h @@ -228,6 +228,8 @@ private: friend struct Condition; friend struct DequeueCondition; friend struct LockCondition; + + int32_t computeTail() const; struct QueueUpdate : public UpdateBase { inline QueueUpdate(SharedBufferBase* sbb); diff --git a/libs/ui/SharedBufferStack.cpp b/libs/ui/SharedBufferStack.cpp index 436d793..7789a3f 100644 --- a/libs/ui/SharedBufferStack.cpp +++ b/libs/ui/SharedBufferStack.cpp @@ -246,19 +246,26 @@ SharedBufferClient::SharedBufferClient(SharedClient* sharedClient, int surface, int num) : SharedBufferBase(sharedClient, surface, num), tail(0) { + tail = computeTail(); +} + +int32_t SharedBufferClient::computeTail() const +{ SharedBufferStack& stack( *mSharedStack ); - int32_t avail; - int32_t head; // we need to make sure we read available and head coherently, // w.r.t RetireUpdate. + int32_t newTail; + int32_t avail; + int32_t head; do { avail = stack.available; head = stack.head; } while (stack.available != avail); - tail = head - avail + 1; - if (tail < 0) { - tail += num; + newTail = head - avail + 1; + if (newTail < 0) { + newTail += mNumBuffers; } + return newTail; } ssize_t SharedBufferClient::dequeue() @@ -296,6 +303,9 @@ status_t SharedBufferClient::undoDequeue(int buf) { UndoDequeueUpdate update(this); status_t err = updateCondition( update ); + if (err == NO_ERROR) { + tail = computeTail(); + } return err; } |