diff options
author | James Dong <jdong@google.com> | 2011-06-17 15:13:42 -0700 |
---|---|---|
committer | James Dong <jdong@google.com> | 2011-06-17 15:28:07 -0700 |
commit | bf8116f28da187933a255ba3719b9265ecd1d98b (patch) | |
tree | e6f96e631648e91f0151714d12ec66c8cabe0f15 | |
parent | 4d4faf9e9119c186d96e0918fc9d6395188abd31 (diff) | |
download | frameworks_base-bf8116f28da187933a255ba3719b9265ecd1d98b.zip frameworks_base-bf8116f28da187933a255ba3719b9265ecd1d98b.tar.gz frameworks_base-bf8116f28da187933a255ba3719b9265ecd1d98b.tar.bz2 |
Use system property to control whether we will enable B frame support in MPEG4Writer
o This is to work around a bug in crespo's video encoder output timestamp
related-to-bug: 4600191,4724339
Change-Id: I485c1e044bd2f604b318692efd6433345cfc6487
-rw-r--r-- | media/libstagefright/MPEG4Writer.cpp | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/media/libstagefright/MPEG4Writer.cpp b/media/libstagefright/MPEG4Writer.cpp index 28add18..58f03a0 100644 --- a/media/libstagefright/MPEG4Writer.cpp +++ b/media/libstagefright/MPEG4Writer.cpp @@ -1975,7 +1975,17 @@ status_t MPEG4Writer::Track::threadEntry() { int64_t previousPausedDurationUs = 0; int64_t timestampUs = 0; int64_t cttsDeltaTimeUs = 0; + bool hasBFrames = false; +#if 1 + // XXX: Samsung's video encoder's output buffer timestamp + // is not correct. see bug 4724339 + char value[PROPERTY_VALUE_MAX]; + if (property_get("rw.media.record.hasb", value, NULL) && + (!strcasecmp(value, "true") || !strcasecmp(value, "1"))) { + hasBFrames = true; + } +#endif if (mIsAudio) { prctl(PR_SET_NAME, (unsigned long)"AudioTrackEncoding", 0, 0, 0); } else { @@ -2118,7 +2128,7 @@ status_t MPEG4Writer::Track::threadEntry() { timestampUs -= previousPausedDurationUs; CHECK(timestampUs >= 0); - if (!mIsAudio) { + if (!mIsAudio && hasBFrames) { /* * Composition time: timestampUs * Decoding time: decodingTimeUs |