diff options
author | Bob Lee <crazybob@google.com> | 2009-07-10 14:13:37 -0700 |
---|---|---|
committer | Bob Lee <crazybob@google.com> | 2009-07-10 14:13:37 -0700 |
commit | c8e852da32cd91b708ee53d69fbe9bba2e08ffec (patch) | |
tree | a583b5707419183669941f60eb526d9d2beb1134 | |
parent | 9090ff7937d20bed24ac83eec6853c2ed258ef26 (diff) | |
parent | ad94a98364c02be7a0c5317cad9d57ecec964f80 (diff) | |
download | frameworks_base-c8e852da32cd91b708ee53d69fbe9bba2e08ffec.zip frameworks_base-c8e852da32cd91b708ee53d69fbe9bba2e08ffec.tar.gz frameworks_base-c8e852da32cd91b708ee53d69fbe9bba2e08ffec.tar.bz2 |
resolved conflicts for merge of ad94a983 to master
-rw-r--r-- | core/java/android/net/Uri.java | 21 | ||||
-rwxr-xr-x | tests/AndroidTests/run_test.sh | 2 | ||||
-rw-r--r-- | tests/AndroidTests/src/com/android/unit_tests/UriTest.java | 4 |
3 files changed, 17 insertions, 10 deletions
diff --git a/core/java/android/net/Uri.java b/core/java/android/net/Uri.java index 08bd67e..a490f73 100644 --- a/core/java/android/net/Uri.java +++ b/core/java/android/net/Uri.java @@ -105,6 +105,18 @@ public abstract class Uri implements Parcelable, Comparable<Uri> { private static final String LOG = Uri.class.getSimpleName(); /** + * NOTE: EMPTY accesses this field during its own initialization, so this + * field *must* be initialized first, or else EMPTY will see a null value! + * + * Placeholder for strings which haven't been cached. This enables us + * to cache null. We intentionally create a new String instance so we can + * compare its identity and there is no chance we will confuse it with + * user data. + */ + @SuppressWarnings("RedundantStringConstructorCall") + private static final String NOT_CACHED = new String("NOT CACHED"); + + /** * The empty URI, equivalent to "". */ public static final Uri EMPTY = new HierarchicalUri(null, Part.NULL, @@ -350,15 +362,6 @@ public abstract class Uri implements Parcelable, Comparable<Uri> { private final static int NOT_CALCULATED = -2; /** - * Placeholder for strings which haven't been cached. This enables us - * to cache null. We intentionally create a new String instance so we can - * compare its identity and there is no chance we will confuse it with - * user data. - */ - @SuppressWarnings("RedundantStringConstructorCall") - private static final String NOT_CACHED = new String("NOT CACHED"); - - /** * Error message presented when a user tries to treat an opaque URI as * hierarchical. */ diff --git a/tests/AndroidTests/run_test.sh b/tests/AndroidTests/run_test.sh index 6c3710a..bc06b7e 100755 --- a/tests/AndroidTests/run_test.sh +++ b/tests/AndroidTests/run_test.sh @@ -1,4 +1,4 @@ framework=/system/framework bpath=$framework/core.jar:$framework/ext.jar:$framework/framework.jar:$framework/android.test.runner.jar -adb shell exec dalvikvm -Xbootclasspath:$bpath -cp system/app/AndroidTests.apk:data/app/AndroidTests.apk \ +adb shell exec dalvikvm -Xbootclasspath:$bpath -cp /system/app/AndroidTests.apk:/data/app/com.android.unit_tests.apk:/data/app/AndroidTests.apk \ com.android.internal.util.WithFramework junit.textui.TestRunner $* diff --git a/tests/AndroidTests/src/com/android/unit_tests/UriTest.java b/tests/AndroidTests/src/com/android/unit_tests/UriTest.java index 130beeb..e9d3cda 100644 --- a/tests/AndroidTests/src/com/android/unit_tests/UriTest.java +++ b/tests/AndroidTests/src/com/android/unit_tests/UriTest.java @@ -499,4 +499,8 @@ public class UriTest extends TestCase { assertEquals(uriString, uri.toString()); } + + public void testEmptyToStringNotNull() { + assertNotNull(Uri.EMPTY.toString()); + } } |