diff options
author | Dianne Hackborn <hackbod@google.com> | 2012-09-21 17:05:47 -0700 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2012-09-21 17:05:47 -0700 |
commit | c9e94ea6451958fce107580b54c183181de6aa22 (patch) | |
tree | 23a78dbd149ea7307989a0fe6f9685e65fc30fde | |
parent | 8562cb59825a9ccff2b019d2c30f38c8798ca3a1 (diff) | |
parent | 52c62344c585662d6b441a08c2a69a5732255a6f (diff) | |
download | frameworks_base-c9e94ea6451958fce107580b54c183181de6aa22.zip frameworks_base-c9e94ea6451958fce107580b54c183181de6aa22.tar.gz frameworks_base-c9e94ea6451958fce107580b54c183181de6aa22.tar.bz2 |
Merge "Fix issue #7213113: Remove old intent resolver" into jb-mr1-dev
-rwxr-xr-x | core/java/android/widget/AppSecurityPermissions.java | 2 | ||||
-rw-r--r-- | core/res/AndroidManifest.xml | 1 | ||||
-rw-r--r-- | services/java/com/android/server/IntentResolver.java | 27 |
3 files changed, 19 insertions, 11 deletions
diff --git a/core/java/android/widget/AppSecurityPermissions.java b/core/java/android/widget/AppSecurityPermissions.java index 27d15f6..06dadb0 100755 --- a/core/java/android/widget/AppSecurityPermissions.java +++ b/core/java/android/widget/AppSecurityPermissions.java @@ -257,7 +257,7 @@ public class AppSecurityPermissions { try { pkgInfo = mPm.getPackageInfo(packageName, PackageManager.GET_PERMISSIONS); } catch (NameNotFoundException e) { - Log.w(TAG, "Could'nt retrieve permissions for package:"+packageName); + Log.w(TAG, "Couldn't retrieve permissions for package:"+packageName); return; } // Extract all user permissions diff --git a/core/res/AndroidManifest.xml b/core/res/AndroidManifest.xml index 661b70c..a8bee4d 100644 --- a/core/res/AndroidManifest.xml +++ b/core/res/AndroidManifest.xml @@ -45,6 +45,7 @@ <protected-broadcast android:name="android.intent.action.PACKAGE_NEEDS_VERIFICATION" /> <protected-broadcast android:name="android.intent.action.PACKAGE_VERIFIED" /> <protected-broadcast android:name="android.intent.action.UID_REMOVED" /> + <protected-broadcast android:name="android.intent.action.QUERY_PACKAGE_RESTART" /> <protected-broadcast android:name="android.intent.action.CONFIGURATION_CHANGED" /> <protected-broadcast android:name="android.intent.action.LOCALE_CHANGED" /> <protected-broadcast android:name="android.intent.action.BATTERY_CHANGED" /> diff --git a/services/java/com/android/server/IntentResolver.java b/services/java/com/android/server/IntentResolver.java index d4769e8..9b19008 100644 --- a/services/java/com/android/server/IntentResolver.java +++ b/services/java/com/android/server/IntentResolver.java @@ -46,6 +46,7 @@ public abstract class IntentResolver<F extends IntentFilter, R extends Object> { final private static String TAG = "IntentResolver"; final private static boolean DEBUG = false; final private static boolean localLOGV = DEBUG || false; + final private static boolean VALIDATE = false; public void addFilter(F f) { if (localLOGV) { @@ -67,16 +68,20 @@ public abstract class IntentResolver<F extends IntentFilter, R extends Object> { mTypedActionToFilter, " TypedAction: "); } - mOldResolver.addFilter(f); - verifyDataStructures(f); + if (VALIDATE) { + mOldResolver.addFilter(f); + verifyDataStructures(f); + } } public void removeFilter(F f) { removeFilterInternal(f); mFilters.remove(f); - mOldResolver.removeFilter(f); - verifyDataStructures(f); + if (VALIDATE) { + mOldResolver.removeFilter(f); + verifyDataStructures(f); + } } void removeFilterInternal(F f) { @@ -314,12 +319,14 @@ public abstract class IntentResolver<F extends IntentFilter, R extends Object> { } sortResults(finalList); - List<R> oldList = mOldResolver.queryIntent(intent, resolvedType, defaultOnly, userId); - if (oldList.size() != finalList.size()) { - ValidationFailure here = new ValidationFailure(); - here.fillInStackTrace(); - Log.wtf(TAG, "Query result " + intent + " size is " + finalList.size() - + "; old implementation is " + oldList.size(), here); + if (VALIDATE) { + List<R> oldList = mOldResolver.queryIntent(intent, resolvedType, defaultOnly, userId); + if (oldList.size() != finalList.size()) { + ValidationFailure here = new ValidationFailure(); + here.fillInStackTrace(); + Log.wtf(TAG, "Query result " + intent + " size is " + finalList.size() + + "; old implementation is " + oldList.size(), here); + } } if (debug) { |