diff options
author | Craig Mautner <cmautner@google.com> | 2013-10-09 19:10:44 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2013-10-09 19:10:45 +0000 |
commit | e8a057a9aea661a9398ddaa3161e7ea6ab6675b8 (patch) | |
tree | a7f875fc643c122e4e7243c188e76a2acc21b4fc | |
parent | 92128144d95e913a6702586cf4f0468bcb90c0c4 (diff) | |
parent | 4e8a19c73a0b4ca91ea963230948841054495631 (diff) | |
download | frameworks_base-e8a057a9aea661a9398ddaa3161e7ea6ab6675b8.zip frameworks_base-e8a057a9aea661a9398ddaa3161e7ea6ab6675b8.tar.gz frameworks_base-e8a057a9aea661a9398ddaa3161e7ea6ab6675b8.tar.bz2 |
Merge "Remove overly tight constraint on drawn Keyguard." into klp-dev
3 files changed, 9 insertions, 10 deletions
diff --git a/packages/Keyguard/src/com/android/keyguard/KeyguardViewManager.java b/packages/Keyguard/src/com/android/keyguard/KeyguardViewManager.java index 6584180..58ca0b0 100644 --- a/packages/Keyguard/src/com/android/keyguard/KeyguardViewManager.java +++ b/packages/Keyguard/src/com/android/keyguard/KeyguardViewManager.java @@ -420,6 +420,7 @@ public class KeyguardViewManager { public synchronized void onScreenTurnedOn(final IKeyguardShowCallback callback) { if (DEBUG) Log.d(TAG, "onScreenTurnedOn()"); mScreenOn = true; + final IBinder token = mKeyguardHost == null ? null : mKeyguardHost.getWindowToken(); if (mKeyguardView != null) { mKeyguardView.onScreenTurnedOn(); @@ -432,10 +433,6 @@ public class KeyguardViewManager { mKeyguardHost.post(new Runnable() { @Override public void run() { - IBinder token = null; - if (mKeyguardHost.getVisibility() == View.VISIBLE) { - token = mKeyguardHost.getWindowToken(); - } try { callback.onShown(token); } catch (RemoteException e) { @@ -445,7 +442,7 @@ public class KeyguardViewManager { }); } else { try { - callback.onShown(null); + callback.onShown(token); } catch (RemoteException e) { Slog.w(TAG, "Exception calling onShown():", e); } @@ -453,7 +450,7 @@ public class KeyguardViewManager { } } else if (callback != null) { try { - callback.onShown(null); + callback.onShown(token); } catch (RemoteException e) { Slog.w(TAG, "Exception calling onShown():", e); } diff --git a/policy/src/com/android/internal/policy/impl/PhoneWindowManager.java b/policy/src/com/android/internal/policy/impl/PhoneWindowManager.java index adbada7..8b6b60a 100644 --- a/policy/src/com/android/internal/policy/impl/PhoneWindowManager.java +++ b/policy/src/com/android/internal/policy/impl/PhoneWindowManager.java @@ -4282,12 +4282,14 @@ public class PhoneWindowManager implements WindowManagerPolicy { })) { return; } + Slog.i(TAG, "No lock screen! waitForWindowDrawn false"); + } catch (RemoteException ex) { // Can't happen in system process. } } - Slog.i(TAG, "No lock screen!"); + Slog.i(TAG, "No lock screen! windowToken=" + windowToken); finishScreenTurningOn(screenOnListener); } diff --git a/services/java/com/android/server/wm/WindowManagerService.java b/services/java/com/android/server/wm/WindowManagerService.java index e089ca6..0fc10f9 100644 --- a/services/java/com/android/server/wm/WindowManagerService.java +++ b/services/java/com/android/server/wm/WindowManagerService.java @@ -9473,9 +9473,8 @@ public class WindowManagerService extends IWindowManager.Stub //Slog.i(TAG, "Waiting for drawn " + win + ": removed=" // + win.mRemoved + " visible=" + win.isVisibleLw() // + " shown=" + win.mSurfaceShown); - if (win.mRemoved || !win.isVisibleLw()) { - // Window has been removed or made invisible; no draw - // will now happen, so stop waiting. + if (win.mRemoved) { + // Window has been removed; no draw will now happen, so stop waiting. Slog.w(TAG, "Aborted waiting for drawn: " + pair.first); try { pair.second.sendResult(null); @@ -9510,6 +9509,7 @@ public class WindowManagerService extends IWindowManager.Stub checkDrawnWindowsLocked(); return true; } + Slog.i(TAG, "waitForWindowDrawn: win null"); } } return false; |