summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHuahui Wu <hwu@google.com>2011-01-24 12:07:37 -0800
committerHuahui Wu <hwu@google.com>2011-01-24 12:07:37 -0800
commitf93246923f0a8c85fddb508533d63d59977f75eb (patch)
treee8e9764d83bcd55892ba650bd82cb4e3489f3de2
parentda6f9295840b0e74f61afa273ce2a767d8148af7 (diff)
downloadframeworks_base-f93246923f0a8c85fddb508533d63d59977f75eb.zip
frameworks_base-f93246923f0a8c85fddb508533d63d59977f75eb.tar.gz
frameworks_base-f93246923f0a8c85fddb508533d63d59977f75eb.tar.bz2
A few small cleanning-ups.
1. Remove mDeferMultiTouch in WebView, it was for testing only but we don't need it now since we always pass MultiTouch to WebKit. 2. Remove the use of mDeferMultiTouch in DRT tests. 3. Correct the index of getX(Y) for the second touch point in the debug string of MotionEvent. Change-Id: Ib63cfc5935af1a169ed26b2b138f74908492bc18
-rw-r--r--core/java/android/view/MotionEvent.java2
-rw-r--r--core/java/android/webkit/WebView.java14
-rw-r--r--tests/DumpRenderTree/src/com/android/dumprendertree/TestShellActivity.java4
-rw-r--r--tests/DumpRenderTree2/src/com/android/dumprendertree2/LayoutTestsExecutor.java1
4 files changed, 1 insertions, 20 deletions
diff --git a/core/java/android/view/MotionEvent.java b/core/java/android/view/MotionEvent.java
index db2cd50..b95de64 100644
--- a/core/java/android/view/MotionEvent.java
+++ b/core/java/android/view/MotionEvent.java
@@ -1569,7 +1569,7 @@ public final class MotionEvent extends InputEvent implements Parcelable {
+ " device=" + mDeviceId
+ " source=0x" + Integer.toHexString(mSource)
+ (getPointerCount() > 1 ?
- " pointerId2=" + getPointerId(1) + " x2=" + getX(2) + " y2=" + getY(2) : "")
+ " pointerId2=" + getPointerId(1) + " x2=" + getX(1) + " y2=" + getY(1) : "")
+ "}";
}
diff --git a/core/java/android/webkit/WebView.java b/core/java/android/webkit/WebView.java
index 83061ec..1271ba6 100644
--- a/core/java/android/webkit/WebView.java
+++ b/core/java/android/webkit/WebView.java
@@ -498,9 +498,6 @@ public class WebView extends AbsoluteLayout
// default is not set, the UI will continue handle them.
private boolean mDeferTouchProcess;
- // if true, multi-touch events will be passed to webkit directly before UI
- private boolean mDeferMultitouch = false;
-
// Currently, multi-touch events are sent to WebKit first then back to
// WebView while single-touch events are handled in WebView first.
// So there is a chance that a single-touch move event is handled in WebView
@@ -8165,17 +8162,6 @@ public class WebView extends AbsoluteLayout
}
/**
- * Toggle whether multi touch events should be sent to webkit
- * no matter if UI wants to handle it first.
- *
- * @hide This is only used by the webkit layout test.
- */
- public void setDeferMultiTouch(boolean value) {
- mDeferMultitouch = value;
- Log.v(LOGTAG, "set mDeferMultitouch to " + value);
- }
-
- /**
* Update our cache with updatedText.
* @param updatedText The new text to put in our cache.
*/
diff --git a/tests/DumpRenderTree/src/com/android/dumprendertree/TestShellActivity.java b/tests/DumpRenderTree/src/com/android/dumprendertree/TestShellActivity.java
index 9c4fa97..3ea4911 100644
--- a/tests/DumpRenderTree/src/com/android/dumprendertree/TestShellActivity.java
+++ b/tests/DumpRenderTree/src/com/android/dumprendertree/TestShellActivity.java
@@ -158,10 +158,6 @@ public class TestShellActivity extends Activity implements LayoutTestController
// WebView::setJsFlags is noop in JSC build.
mWebView.setJsFlags("--expose_gc");
- // Always send multitouch events to Webkit since the layout test
- // is only for the Webkit not the browser's UI.
- mWebView.setDeferMultiTouch(true);
-
mHandler = new AsyncHandler();
Intent intent = getIntent();
diff --git a/tests/DumpRenderTree2/src/com/android/dumprendertree2/LayoutTestsExecutor.java b/tests/DumpRenderTree2/src/com/android/dumprendertree2/LayoutTestsExecutor.java
index ce546ec..d9f5dd4 100644
--- a/tests/DumpRenderTree2/src/com/android/dumprendertree2/LayoutTestsExecutor.java
+++ b/tests/DumpRenderTree2/src/com/android/dumprendertree2/LayoutTestsExecutor.java
@@ -372,7 +372,6 @@ public class LayoutTestsExecutor extends Activity {
webView.setTouchInterval(-1);
webView.clearCache(true);
- webView.setDeferMultiTouch(true);
WebSettings webViewSettings = webView.getSettings();
webViewSettings.setAppCacheEnabled(true);