summaryrefslogtreecommitdiffstats
path: root/cmds/backup
diff options
context:
space:
mode:
authorAndreas Gampe <agampe@google.com>2014-09-30 21:48:18 -0700
committerAndreas Gampe <agampe@google.com>2014-11-07 14:33:51 -0800
commitcfedceb8c180a2e176154d461659e0c3569dc931 (patch)
tree00de5f6ee61e72713c3b141f5a308f33f312bf53 /cmds/backup
parent59701b9ba5c453e327bc0e6873a9f6ff87a10391 (diff)
downloadframeworks_base-cfedceb8c180a2e176154d461659e0c3569dc931.zip
frameworks_base-cfedceb8c180a2e176154d461659e0c3569dc931.tar.gz
frameworks_base-cfedceb8c180a2e176154d461659e0c3569dc931.tar.bz2
Frameworks/base: Turn on -Wall -Werror in cmds
Fix small warnings, turn on -Wall -Werror. Change-Id: Iab1f01a7c7ebd6ba832b75067c5e395f380a1b8b
Diffstat (limited to 'cmds/backup')
-rw-r--r--cmds/backup/Android.mk2
-rw-r--r--cmds/backup/backup.cpp14
2 files changed, 7 insertions, 9 deletions
diff --git a/cmds/backup/Android.mk b/cmds/backup/Android.mk
index 42e5133..8e1508c 100644
--- a/cmds/backup/Android.mk
+++ b/cmds/backup/Android.mk
@@ -12,4 +12,6 @@ LOCAL_MODULE:= btool
LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
LOCAL_MODULE_TAGS := optional
+LOCAL_CFLAGS += -Wall -Werror -Wunused -Wunreachable-code
+
include $(BUILD_EXECUTABLE)
diff --git a/cmds/backup/backup.cpp b/cmds/backup/backup.cpp
index ea1888b..03ceffa 100644
--- a/cmds/backup/backup.cpp
+++ b/cmds/backup/backup.cpp
@@ -25,8 +25,7 @@ using namespace android;
#include <unistd.h>
-int
-usage(int argc, const char** argv)
+static int usage(int /* argc */, const char** argv)
{
const char* p = argv[0];
@@ -44,15 +43,13 @@ usage(int argc, const char** argv)
return 1;
}
-int
-perform_full_backup()
+static int perform_full_backup()
{
printf("this would have written all of your data to stdout\n");
return 0;
}
-int
-perform_list(const char* filename)
+static int perform_list(const char* filename)
{
int err;
int fd;
@@ -95,14 +92,13 @@ perform_list(const char* filename)
return 0;
}
-int perform_print(const char* entityname, const char* filename)
+static int perform_print(const char* entityname, const char* filename)
{
printf("perform_print(%s, %s);", entityname, filename);
return 0;
}
-int
-main(int argc, const char** argv)
+int main(int argc, const char** argv)
{
if (argc <= 1) {
return perform_full_backup();