diff options
author | Android (Google) Code Review <android-gerrit@google.com> | 2009-10-30 13:23:43 -0400 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2009-10-30 13:23:43 -0400 |
commit | 3cf254d2ba303da3354ed65fd7f3136e87a56b9f (patch) | |
tree | 24a119200178864f55c14a6f3f23ec90944a7cbb /core/java/android/bluetooth/BluetoothAdapter.java | |
parent | 824838d74eb0316f6987a1d98d2d9e9fa8d4e15b (diff) | |
parent | 4b3db907f04d85cd20e0a0e35056ba44a10e8867 (diff) | |
download | frameworks_base-3cf254d2ba303da3354ed65fd7f3136e87a56b9f.zip frameworks_base-3cf254d2ba303da3354ed65fd7f3136e87a56b9f.tar.gz frameworks_base-3cf254d2ba303da3354ed65fd7f3136e87a56b9f.tar.bz2 |
Merge change I4b3db907 into eclair
* changes:
Revert the channge where channels were not selected randomly.
Diffstat (limited to 'core/java/android/bluetooth/BluetoothAdapter.java')
-rw-r--r-- | core/java/android/bluetooth/BluetoothAdapter.java | 23 |
1 files changed, 4 insertions, 19 deletions
diff --git a/core/java/android/bluetooth/BluetoothAdapter.java b/core/java/android/bluetooth/BluetoothAdapter.java index ff48583..3fc676b 100644 --- a/core/java/android/bluetooth/BluetoothAdapter.java +++ b/core/java/android/bluetooth/BluetoothAdapter.java @@ -597,14 +597,6 @@ public final class BluetoothAdapter { /** * Picks RFCOMM channels until none are left. * Avoids reserved channels. - * Ideally we would pick random channels, but in the current implementation - * we start with the channel that is the hash of the UUID, and try every - * available channel from there. This means that in most cases a given - * uuid will use the same channel. This is a workaround for a Bluez SDP - * bug where we are not updating the cache when the channel changes for a - * uuid. - * TODO: Fix the Bluez SDP caching bug, and go back to random channel - * selection */ private static class RfcommChannelPicker { private static final int[] RESERVED_RFCOMM_CHANNELS = new int[] { @@ -637,19 +629,12 @@ public final class BluetoothAdapter { } mUuid = uuid; } - /* Returns next channel, or -1 if we're out */ + /* Returns next random channel, or -1 if we're out */ public int nextChannel() { - int channel = mUuid.hashCode(); // always pick the same channel to try first - Integer channelInt; - while (mChannels.size() > 0) { - channelInt = new Integer(channel); - if (mChannels.remove(channelInt)) { - return channel; - } - channel = (channel % BluetoothSocket.MAX_RFCOMM_CHANNEL) + 1; + if (mChannels.size() == 0) { + return -1; } - - return -1; + return mChannels.remove(sRandom.nextInt(mChannels.size())); } } |