summaryrefslogtreecommitdiffstats
path: root/core/java/android/server/search
diff options
context:
space:
mode:
authorMike LeBeau <mlebeau@android.com>2009-07-09 14:17:12 -0700
committerMike LeBeau <mlebeau@android.com>2009-07-09 14:17:12 -0700
commitf4422ce8293bdb4b6d9f091d38ab588d0bb2e4e4 (patch)
tree7f2b71e1081714bc81b952b381edf7fd409ec112 /core/java/android/server/search
parente57ff0e1db46559699e4fadfbe9abe67ef9472fe (diff)
downloadframeworks_base-f4422ce8293bdb4b6d9f091d38ab588d0bb2e4e4.zip
frameworks_base-f4422ce8293bdb4b6d9f091d38ab588d0bb2e4e4.tar.gz
frameworks_base-f4422ce8293bdb4b6d9f091d38ab588d0bb2e4e4.tar.bz2
Check if a searchable is null before adding it to the list of searchables
for web search. If getActivityMetaData returned null for a web search searchable, previously, this null would get added to the list of searchables for web search, which was causing GlobalSearch's SearchSettings to crash with an NPE (which I've guarded against in change 6602).
Diffstat (limited to 'core/java/android/server/search')
-rw-r--r--core/java/android/server/search/Searchables.java7
1 files changed, 6 insertions, 1 deletions
diff --git a/core/java/android/server/search/Searchables.java b/core/java/android/server/search/Searchables.java
index b959907..c615957 100644
--- a/core/java/android/server/search/Searchables.java
+++ b/core/java/android/server/search/Searchables.java
@@ -247,7 +247,12 @@ public class Searchables {
for (int i = 0; i < webSearchInfoList.size(); ++i) {
ActivityInfo ai = webSearchInfoList.get(i).activityInfo;
ComponentName component = new ComponentName(ai.packageName, ai.name);
- newSearchablesForWebSearchList.add(newSearchablesMap.get(component));
+ SearchableInfo searchable = newSearchablesMap.get(component);
+ if (searchable == null) {
+ Log.w(LOG_TAG, "did not find component in searchables: " + component);
+ } else {
+ newSearchablesForWebSearchList.add(searchable);
+ }
}
}