summaryrefslogtreecommitdiffstats
path: root/core/java/android/view
diff options
context:
space:
mode:
authorChris Craik <ccraik@google.com>2015-05-01 21:01:13 +0000
committerAndroid (Google) Code Review <android-gerrit@google.com>2015-05-01 21:01:14 +0000
commit5c705c595d6adbb4b6e8ad5dee29205246cd5cc4 (patch)
tree829152c2c5dd85444adfa8c31ad21763f5a63ad7 /core/java/android/view
parentf4ff8f701f8127ad9e187a30e9407375695a4b62 (diff)
parentb2847afde24aac22c8fb804cdce0c24b8a7c40c4 (diff)
downloadframeworks_base-5c705c595d6adbb4b6e8ad5dee29205246cd5cc4.zip
frameworks_base-5c705c595d6adbb4b6e8ad5dee29205246cd5cc4.tar.gz
frameworks_base-5c705c595d6adbb4b6e8ad5dee29205246cd5cc4.tar.bz2
Merge "Fix build." into mnc-dev
Diffstat (limited to 'core/java/android/view')
-rw-r--r--core/java/android/view/GhostView.java6
-rw-r--r--core/java/android/view/ThreadedRenderer.java4
-rw-r--r--core/java/android/view/View.java22
-rw-r--r--core/java/android/view/ViewGroup.java5
-rw-r--r--core/java/android/view/ViewRootImpl.java2
5 files changed, 26 insertions, 13 deletions
diff --git a/core/java/android/view/GhostView.java b/core/java/android/view/GhostView.java
index bc38e1a..d58e7c0 100644
--- a/core/java/android/view/GhostView.java
+++ b/core/java/android/view/GhostView.java
@@ -41,7 +41,7 @@ public class GhostView extends View {
final ViewGroup parent = (ViewGroup) mView.getParent();
setGhostedVisibility(View.INVISIBLE);
parent.mRecreateDisplayList = true;
- parent.updateDisplayListIfDirty();
+ parent.getDisplayList();
}
@Override
@@ -49,7 +49,7 @@ public class GhostView extends View {
if (canvas instanceof DisplayListCanvas) {
DisplayListCanvas dlCanvas = (DisplayListCanvas) canvas;
mView.mRecreateDisplayList = true;
- RenderNode renderNode = mView.updateDisplayListIfDirty();
+ RenderNode renderNode = mView.getDisplayList();
if (renderNode.isValid()) {
dlCanvas.insertReorderBarrier(); // enable shadow for this rendernode
dlCanvas.drawRenderNode(renderNode);
@@ -84,7 +84,7 @@ public class GhostView extends View {
final ViewGroup parent = (ViewGroup) mView.getParent();
if (parent != null) {
parent.mRecreateDisplayList = true;
- parent.updateDisplayListIfDirty();
+ parent.getDisplayList();
}
}
}
diff --git a/core/java/android/view/ThreadedRenderer.java b/core/java/android/view/ThreadedRenderer.java
index 390d81d..5017a38 100644
--- a/core/java/android/view/ThreadedRenderer.java
+++ b/core/java/android/view/ThreadedRenderer.java
@@ -269,7 +269,7 @@ public class ThreadedRenderer extends HardwareRenderer {
view.mRecreateDisplayList = (view.mPrivateFlags & View.PFLAG_INVALIDATED)
== View.PFLAG_INVALIDATED;
view.mPrivateFlags &= ~View.PFLAG_INVALIDATED;
- view.updateDisplayListIfDirty();
+ view.getDisplayList();
view.mRecreateDisplayList = false;
}
@@ -285,7 +285,7 @@ public class ThreadedRenderer extends HardwareRenderer {
callbacks.onHardwarePreDraw(canvas);
canvas.insertReorderBarrier();
- canvas.drawRenderNode(view.updateDisplayListIfDirty());
+ canvas.drawRenderNode(view.getDisplayList());
canvas.insertInorderBarrier();
callbacks.onHardwarePostDraw(canvas);
diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java
index 8efaeab..ed0ceb2 100644
--- a/core/java/android/view/View.java
+++ b/core/java/android/view/View.java
@@ -14711,11 +14711,11 @@ public class View implements Drawable.Callback, KeyEvent.Callback,
return !(mAttachInfo == null || mAttachInfo.mHardwareRenderer == null);
}
- RenderNode updateDisplayListIfDirty() {
+ private void updateDisplayListIfDirty() {
final RenderNode renderNode = mRenderNode;
if (!canHaveDisplayList()) {
// can't populate RenderNode, don't try
- return renderNode;
+ return;
}
if ((mPrivateFlags & PFLAG_DRAWING_CACHE_VALID) == 0
@@ -14729,7 +14729,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback,
mPrivateFlags &= ~PFLAG_DIRTY_MASK;
dispatchGetDisplayList();
- return renderNode; // no work needed
+ return; // no work needed
}
// If we got here, we're recreating it. Mark it as such to ensure that
@@ -14778,7 +14778,19 @@ public class View implements Drawable.Callback, KeyEvent.Callback,
mPrivateFlags |= PFLAG_DRAWN | PFLAG_DRAWING_CACHE_VALID;
mPrivateFlags &= ~PFLAG_DIRTY_MASK;
}
- return renderNode;
+ }
+
+ /**
+ * Returns a RenderNode with View draw content recorded, which can be
+ * used to draw this view again without executing its draw method.
+ *
+ * @return A RenderNode ready to replay, or null if caching is not enabled.
+ *
+ * @hide
+ */
+ public RenderNode getDisplayList() {
+ updateDisplayListIfDirty();
+ return mRenderNode;
}
private void resetDisplayList() {
@@ -15540,7 +15552,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback,
if (drawingWithRenderNode) {
// Delay getting the display list until animation-driven alpha values are
// set up and possibly passed on to the view
- renderNode = updateDisplayListIfDirty();
+ renderNode = getDisplayList();
if (!renderNode.isValid()) {
// Uncommon, but possible. If a view is removed from the hierarchy during the call
// to getDisplayList(), the display list will be marked invalid and we should not
diff --git a/core/java/android/view/ViewGroup.java b/core/java/android/view/ViewGroup.java
index ef57dc3..d0d4201 100644
--- a/core/java/android/view/ViewGroup.java
+++ b/core/java/android/view/ViewGroup.java
@@ -3524,9 +3524,10 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager
}
private void recreateChildDisplayList(View child) {
- child.mRecreateDisplayList = (child.mPrivateFlags & PFLAG_INVALIDATED) != 0;
+ child.mRecreateDisplayList = (child.mPrivateFlags & PFLAG_INVALIDATED)
+ == PFLAG_INVALIDATED;
child.mPrivateFlags &= ~PFLAG_INVALIDATED;
- child.updateDisplayListIfDirty();
+ child.getDisplayList();
child.mRecreateDisplayList = false;
}
diff --git a/core/java/android/view/ViewRootImpl.java b/core/java/android/view/ViewRootImpl.java
index 2860514..4158340 100644
--- a/core/java/android/view/ViewRootImpl.java
+++ b/core/java/android/view/ViewRootImpl.java
@@ -2322,7 +2322,7 @@ public final class ViewRootImpl implements ViewParent,
* @hide
*/
void outputDisplayList(View view) {
- RenderNode renderNode = view.updateDisplayListIfDirty();
+ RenderNode renderNode = view.getDisplayList();
if (renderNode != null) {
renderNode.output();
}