diff options
author | Svetoslav Ganov <svetoslavganov@google.com> | 2012-01-17 14:36:46 -0800 |
---|---|---|
committer | Svetoslav Ganov <svetoslavganov@google.com> | 2012-01-17 14:51:45 -0800 |
commit | 8a78fd4d9572dff95432fcc4ba0e87563415b728 (patch) | |
tree | 14e2d6c5bcf4c63cd6be048b74ca20188a764d9e /core/java/android/widget/Spinner.java | |
parent | 32313b161f7c7d17841bf49b3d146fd19dd7fde1 (diff) | |
download | frameworks_base-8a78fd4d9572dff95432fcc4ba0e87563415b728.zip frameworks_base-8a78fd4d9572dff95432fcc4ba0e87563415b728.tar.gz frameworks_base-8a78fd4d9572dff95432fcc4ba0e87563415b728.tar.bz2 |
AccessibilityEvent/AccessibilityNodeInfo class name property should be set to only framework classes.
AccessibilityEvent and AccessibilityNodeInfo have a property className which is set to the source
Java class. This is problematic since leads to leaking private classes which would allow an
accessibility service to load classes from other packages. This is strongly undesirable since
not trusted code can be loaded, and hence executed, in the accessibility service. To address
that the class name is set to the most concrete framework class extended by the info/event
source.
bug:5878943
Change-Id: I7b3114ece8772ea2773f5151e21b8a6f2006882a
Diffstat (limited to 'core/java/android/widget/Spinner.java')
-rw-r--r-- | core/java/android/widget/Spinner.java | 16 |
1 files changed, 15 insertions, 1 deletions
diff --git a/core/java/android/widget/Spinner.java b/core/java/android/widget/Spinner.java index ec3790e..ecf19b3 100644 --- a/core/java/android/widget/Spinner.java +++ b/core/java/android/widget/Spinner.java @@ -29,6 +29,8 @@ import android.util.AttributeSet; import android.view.Gravity; import android.view.View; import android.view.ViewGroup; +import android.view.accessibility.AccessibilityEvent; +import android.view.accessibility.AccessibilityNodeInfo; /** @@ -456,12 +458,24 @@ public class Spinner extends AbsSpinner implements OnClickListener { return handled; } - + public void onClick(DialogInterface dialog, int which) { setSelection(which); dialog.dismiss(); } + @Override + public void onInitializeAccessibilityEvent(AccessibilityEvent event) { + super.onInitializeAccessibilityEvent(event); + event.setClassName(Spinner.class.getName()); + } + + @Override + public void onInitializeAccessibilityNodeInfo(AccessibilityNodeInfo info) { + super.onInitializeAccessibilityNodeInfo(info); + info.setClassName(Spinner.class.getName()); + } + /** * Sets the prompt to display when the dialog is shown. * @param prompt the prompt to set |