diff options
author | Alan Viverette <alanv@google.com> | 2015-01-05 20:11:57 +0000 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2015-01-05 20:11:57 +0000 |
commit | 97b2d185b655186664ce5402fbce37faaafddf1d (patch) | |
tree | c3ba557b56a6a3c9869f32a011902ce5b1efd95f /core/java/android/widget | |
parent | b7974bd31d06d439cb75f8a3a0ad032fa689c729 (diff) | |
parent | db7eefbbfdc8c77c03b43fd58bcd461b8e52b20e (diff) | |
download | frameworks_base-97b2d185b655186664ce5402fbce37faaafddf1d.zip frameworks_base-97b2d185b655186664ce5402fbce37faaafddf1d.tar.gz frameworks_base-97b2d185b655186664ce5402fbce37faaafddf1d.tar.bz2 |
am db7eefbb: am dd508581: Use min when comparing AM and PM text lengths
* commit 'db7eefbbfdc8c77c03b43fd58bcd461b8e52b20e':
Use min when comparing AM and PM text lengths
Diffstat (limited to 'core/java/android/widget')
-rw-r--r-- | core/java/android/widget/TimePickerClockDelegate.java | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/core/java/android/widget/TimePickerClockDelegate.java b/core/java/android/widget/TimePickerClockDelegate.java index 8d475a7..b70595a 100644 --- a/core/java/android/widget/TimePickerClockDelegate.java +++ b/core/java/android/widget/TimePickerClockDelegate.java @@ -1051,15 +1051,16 @@ class TimePickerClockDelegate extends TimePicker.AbstractTimePickerDelegate impl // Cache the codes. if (mAmKeyCode == -1 || mPmKeyCode == -1) { // Find the first character in the AM/PM text that is unique. - KeyCharacterMap kcm = KeyCharacterMap.load(KeyCharacterMap.VIRTUAL_KEYBOARD); - char amChar; - char pmChar; - for (int i = 0; i < Math.max(mAmText.length(), mPmText.length()); i++) { - amChar = mAmText.toLowerCase(mCurrentLocale).charAt(i); - pmChar = mPmText.toLowerCase(mCurrentLocale).charAt(i); + final KeyCharacterMap kcm = KeyCharacterMap.load(KeyCharacterMap.VIRTUAL_KEYBOARD); + final CharSequence amText = mAmText.toLowerCase(mCurrentLocale); + final CharSequence pmText = mPmText.toLowerCase(mCurrentLocale); + final int N = Math.min(amText.length(), pmText.length()); + for (int i = 0; i < N; i++) { + final char amChar = amText.charAt(i); + final char pmChar = pmText.charAt(i); if (amChar != pmChar) { - KeyEvent[] events = kcm.getEvents(new char[]{amChar, pmChar}); // There should be 4 events: a down and up for both AM and PM. + final KeyEvent[] events = kcm.getEvents(new char[] { amChar, pmChar }); if (events != null && events.length == 4) { mAmKeyCode = events[0].getKeyCode(); mPmKeyCode = events[2].getKeyCode(); @@ -1070,6 +1071,7 @@ class TimePickerClockDelegate extends TimePicker.AbstractTimePickerDelegate impl } } } + if (amOrPm == AM) { return mAmKeyCode; } else if (amOrPm == PM) { |