summaryrefslogtreecommitdiffstats
path: root/core/java/android
diff options
context:
space:
mode:
authorRaph Levien <raph@google.com>2015-06-01 12:40:42 -0700
committerRaph Levien <raph@google.com>2015-06-01 12:40:42 -0700
commit5730c974800a0ffed59a041d9e249a5c42e417db (patch)
treeaa08186b01f46316a054437ee092fee8ade73490 /core/java/android
parentef24bc00399ceb627e9780f05eb68f955e6bd495 (diff)
downloadframeworks_base-5730c974800a0ffed59a041d9e249a5c42e417db.zip
frameworks_base-5730c974800a0ffed59a041d9e249a5c42e417db.tar.gz
frameworks_base-5730c974800a0ffed59a041d9e249a5c42e417db.tar.bz2
Revert "Use getRunAdvance to position cursor"
This reverts commit cb5499c85097450c48f66f6c08a35bab2ad5ab12. Bug: 21549197
Diffstat (limited to 'core/java/android')
-rw-r--r--core/java/android/text/Layout.java1
-rw-r--r--core/java/android/text/TextLine.java10
2 files changed, 6 insertions, 5 deletions
diff --git a/core/java/android/text/Layout.java b/core/java/android/text/Layout.java
index f7027f9..f176240 100644
--- a/core/java/android/text/Layout.java
+++ b/core/java/android/text/Layout.java
@@ -1121,7 +1121,6 @@ public abstract class Layout {
* closest to the specified horizontal position.
*/
public int getOffsetForHorizontal(int line, float horiz) {
- // TODO: use Paint.getOffsetForAdvance to avoid binary search
int max = getLineEnd(line) - 1;
int min = getLineStart(line);
Directions dirs = getLineDirections(line);
diff --git a/core/java/android/text/TextLine.java b/core/java/android/text/TextLine.java
index 605b91d..479242c 100644
--- a/core/java/android/text/TextLine.java
+++ b/core/java/android/text/TextLine.java
@@ -739,14 +739,16 @@ class TextLine {
float ret = 0;
+ int contextLen = contextEnd - contextStart;
if (needWidth || (c != null && (wp.bgColor != 0 || wp.underlineColor != 0 || runIsRtl))) {
if (mCharsValid) {
- ret = wp.getRunAdvance(mChars, start, contextEnd, contextStart, contextEnd,
- runIsRtl, end);
+ ret = wp.getTextRunAdvances(mChars, start, runLen,
+ contextStart, contextLen, runIsRtl, null, 0);
} else {
int delta = mStart;
- ret = wp.getRunAdvance(mText, delta + start, delta + contextEnd,
- delta + contextStart, delta + contextEnd, runIsRtl, delta + end);
+ ret = wp.getTextRunAdvances(mText, delta + start,
+ delta + end, delta + contextStart, delta + contextEnd,
+ runIsRtl, null, 0);
}
}