diff options
author | Svet Ganov <svetoslavganov@google.com> | 2014-10-31 16:56:52 -0700 |
---|---|---|
committer | Svetoslav Ganov <svetoslavganov@google.com> | 2014-11-01 00:06:08 +0000 |
commit | fce84f035c35606c5707e735f503f7bdcfd5b2a1 (patch) | |
tree | c1c7d85246023ab80c6f25df8e47e390f907ddfa /core/java/android | |
parent | e1678ddf7a8311c79ccba5a6b6183f9484fa1f1f (diff) | |
download | frameworks_base-fce84f035c35606c5707e735f503f7bdcfd5b2a1.zip frameworks_base-fce84f035c35606c5707e735f503f7bdcfd5b2a1.tar.gz frameworks_base-fce84f035c35606c5707e735f503f7bdcfd5b2a1.tar.bz2 |
Crash apps that print malformed or password protected PDFs.
If apps are writing malformed content (typically not a PDF file) or if the
PDF content they provide to the print system is password protected, are now
crashed as both of these are app bugs.
bug:17636435
Change-Id: Ifce6a3199e587448dd38f6a84290a965c24b698b
Diffstat (limited to 'core/java/android')
-rw-r--r-- | core/java/android/print/IPrintDocumentAdapter.aidl | 1 | ||||
-rw-r--r-- | core/java/android/print/PrintManager.java | 21 |
2 files changed, 22 insertions, 0 deletions
diff --git a/core/java/android/print/IPrintDocumentAdapter.aidl b/core/java/android/print/IPrintDocumentAdapter.aidl index 9d384fb..8f33e0b 100644 --- a/core/java/android/print/IPrintDocumentAdapter.aidl +++ b/core/java/android/print/IPrintDocumentAdapter.aidl @@ -37,4 +37,5 @@ oneway interface IPrintDocumentAdapter { void write(in PageRange[] pages, in ParcelFileDescriptor fd, IWriteResultCallback callback, int sequence); void finish(); + void kill(String reason); } diff --git a/core/java/android/print/PrintManager.java b/core/java/android/print/PrintManager.java index bf8ac65..3fb812e 100644 --- a/core/java/android/print/PrintManager.java +++ b/core/java/android/print/PrintManager.java @@ -634,6 +634,17 @@ public final class PrintManager { } @Override + public void kill(String reason) { + synchronized (mLock) { + // If destroyed the handler is null. + if (!isDestroyedLocked()) { + mHandler.obtainMessage(MyHandler.MSG_ON_KILL, + reason).sendToTarget(); + } + } + } + + @Override public void onActivityPaused(Activity activity) { /* do nothing */ } @@ -719,6 +730,7 @@ public final class PrintManager { public static final int MSG_ON_LAYOUT = 2; public static final int MSG_ON_WRITE = 3; public static final int MSG_ON_FINISH = 4; + public static final int MSG_ON_KILL = 5; public MyHandler(Looper looper) { super(looper, null, true); @@ -794,6 +806,15 @@ public final class PrintManager { } } break; + case MSG_ON_KILL: { + if (DEBUG) { + Log.i(LOG_TAG, "onKill()"); + } + + String reason = (String) message.obj; + throw new RuntimeException(reason); + } + default: { throw new IllegalArgumentException("Unknown message: " + message.what); |