diff options
author | Adam Powell <adamp@google.com> | 2013-11-12 16:20:46 -0800 |
---|---|---|
committer | Adam Powell <adamp@google.com> | 2013-11-12 16:23:29 -0800 |
commit | 2229ca031a326491feea5832e5337e9f8a602dca (patch) | |
tree | 61fa168dee8670f20203f24a96d0ee1337146a35 /core/java/com | |
parent | 6cd206b2aa0039c215fc0a4cc487471c4b3f1496 (diff) | |
download | frameworks_base-2229ca031a326491feea5832e5337e9f8a602dca.zip frameworks_base-2229ca031a326491feea5832e5337e9f8a602dca.tar.gz frameworks_base-2229ca031a326491feea5832e5337e9f8a602dca.tar.bz2 |
Fix an action bar accessibility regression
A previous fix introduced a problem with building content descriptions
for accessibility of the home/up button in one code path while setting
display options flags. Correct the issue and also refresh content
descriptions immediately when setting related attributes one at a
time.
Bug 11542264
Change-Id: I40d07036d1026e8e40c77c47ac377c82edd827b4
Diffstat (limited to 'core/java/com')
-rw-r--r-- | core/java/com/android/internal/widget/ActionBarView.java | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/core/java/com/android/internal/widget/ActionBarView.java b/core/java/com/android/internal/widget/ActionBarView.java index 5f9d8f2..786f5cf 100644 --- a/core/java/com/android/internal/widget/ActionBarView.java +++ b/core/java/com/android/internal/widget/ActionBarView.java @@ -526,7 +526,7 @@ public class ActionBarView extends AbsActionBarView { if (mLogoNavItem != null) { mLogoNavItem.setTitle(title); } - mUpGoerFive.setContentDescription(buildHomeContentDescription()); + updateHomeAccessibility(mUpGoerFive.isEnabled()); } public CharSequence getSubtitle() { @@ -544,7 +544,7 @@ public class ActionBarView extends AbsActionBarView { (!TextUtils.isEmpty(mTitle) || !TextUtils.isEmpty(mSubtitle)); mTitleLayout.setVisibility(visible ? VISIBLE : GONE); } - mUpGoerFive.setContentDescription(buildHomeContentDescription()); + updateHomeAccessibility(mUpGoerFive.isEnabled()); } public void setHomeButtonEnabled(boolean enable) { @@ -681,7 +681,7 @@ public class ActionBarView extends AbsActionBarView { } // Make sure the home button has an accurate content description for accessibility. - updateHomeAccessibility(!mUpGoerFive.isEnabled()); + updateHomeAccessibility(mUpGoerFive.isEnabled()); } public void setIcon(Drawable icon) { @@ -1332,11 +1332,13 @@ public class ActionBarView extends AbsActionBarView { public void setHomeActionContentDescription(CharSequence description) { mHomeDescription = description; + updateHomeAccessibility(mUpGoerFive.isEnabled()); } public void setHomeActionContentDescription(int resId) { mHomeDescriptionRes = resId; mHomeDescription = resId != 0 ? getResources().getText(resId) : null; + updateHomeAccessibility(mUpGoerFive.isEnabled()); } static class SavedState extends BaseSavedState { |