diff options
| author | Gilles Debunne <debunne@google.com> | 2011-10-28 13:41:01 -0700 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2011-10-28 13:41:01 -0700 |
| commit | 4eec98edee3d6eb516e30a7151da13fd726f93a9 (patch) | |
| tree | 7a866a7ecf7669eff137e8965e62b0fb49a8b5b1 /core/java | |
| parent | fe9a2a5471616a3267b30013bce36b13a455c0cd (diff) | |
| parent | 93347c24a77489d614332b8dfa98a3a50092590c (diff) | |
| download | frameworks_base-4eec98edee3d6eb516e30a7151da13fd726f93a9.zip frameworks_base-4eec98edee3d6eb516e30a7151da13fd726f93a9.tar.gz frameworks_base-4eec98edee3d6eb516e30a7151da13fd726f93a9.tar.bz2 | |
Merge "Text handles do not handle scroll correctly" into ics-mr0
Diffstat (limited to 'core/java')
| -rw-r--r-- | core/java/android/widget/TextView.java | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java index 7f03adf..0a2365e 100644 --- a/core/java/android/widget/TextView.java +++ b/core/java/android/widget/TextView.java @@ -9409,8 +9409,8 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener return false; } - int posX = mPositionX + positionX - getScrollX(); - int posY = mPositionY + positionY - getScrollY(); + int posX = mPositionX + positionX; + int posY = mPositionY + positionY; // Offset by 1 to take into account 0.5 and int rounding around getPrimaryHorizontal. return posX >= clip.left - 1 && posX <= clip.right + 1 && @@ -9421,7 +9421,8 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener final int line = mLayout.getLineForOffset(offset); final int lineBottom = mLayout.getLineBottom(line); final int primaryHorizontal = (int) mLayout.getPrimaryHorizontal(offset); - return isVisible(primaryHorizontal, lineBottom); + return isVisible(primaryHorizontal + viewportToContentHorizontalOffset(), + lineBottom + viewportToContentVerticalOffset()); } public void onScrollChanged() { @@ -10561,7 +10562,7 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener mPositionX = (int) (mLayout.getPrimaryHorizontal(offset) - 0.5f - mHotspotX); mPositionY = mLayout.getLineBottom(line); - // Take TextView's padding into account. + // Take TextView's padding and scroll into account. mPositionX += viewportToContentHorizontalOffset(); mPositionY += viewportToContentVerticalOffset(); |
