diff options
author | Grace Kloba <klobag@google.com> | 2009-12-09 15:51:58 -0800 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2009-12-09 15:51:58 -0800 |
commit | 506afbd600d82a324f59ceb875f664ead4338600 (patch) | |
tree | 5aa4c9ffc61874d84bbd729ce6d2956c4e14a62c /core/java | |
parent | cd6e3484c5d8f27d4b870ecdb15b9e205c75bffc (diff) | |
parent | 3f40bd48d278a40603f3f7d7b9d602ecbc09246d (diff) | |
download | frameworks_base-506afbd600d82a324f59ceb875f664ead4338600.zip frameworks_base-506afbd600d82a324f59ceb875f664ead4338600.tar.gz frameworks_base-506afbd600d82a324f59ceb875f664ead4338600.tar.bz2 |
am 3f40bd48: Remove the code where we suspect webkit draw during drag. It was added for the better performance of panning while loading. But it does make sites using touch event look bad as we don\'t have the display tree until touch up.
Merge commit '3f40bd48d278a40603f3f7d7b9d602ecbc09246d' into eclair-mr2-plus-aosp
* commit '3f40bd48d278a40603f3f7d7b9d602ecbc09246d':
Remove the code where we suspect webkit draw during
Diffstat (limited to 'core/java')
-rw-r--r-- | core/java/android/webkit/WebViewCore.java | 26 |
1 files changed, 1 insertions, 25 deletions
diff --git a/core/java/android/webkit/WebViewCore.java b/core/java/android/webkit/WebViewCore.java index 6079773..5ded240 100644 --- a/core/java/android/webkit/WebViewCore.java +++ b/core/java/android/webkit/WebViewCore.java @@ -1592,9 +1592,6 @@ final class WebViewCore { // Used to avoid posting more than one split picture message. private boolean mSplitPictureIsScheduled; - // Used to suspend drawing. - private boolean mDrawIsPaused; - // mRestoreState is set in didFirstLayout(), and reset in the next // webkitDraw after passing it to the UI thread. private RestoreState mRestoreState = null; @@ -1713,17 +1710,6 @@ final class WebViewCore { sWebCoreHandler.removeMessages(WebCoreThread.RESUME_PRIORITY); sWebCoreHandler.sendMessageAtFrontOfQueue(sWebCoreHandler .obtainMessage(WebCoreThread.REDUCE_PRIORITY)); - // Note: there is one possible failure mode. If pauseUpdate() is called - // from UI thread while in webcore thread WEBKIT_DRAW is just pulled out - // of the queue and about to be executed. mDrawIsScheduled may be set to - // false in webkitDraw(). So update won't be blocked. But at least the - // webcore thread priority is still lowered. - if (core != null) { - synchronized (core) { - core.mDrawIsPaused = true; - core.mEventHub.removeMessages(EventHub.WEBKIT_DRAW); - } - } } static void resumeUpdate(WebViewCore core) { @@ -1732,14 +1718,6 @@ final class WebViewCore { sWebCoreHandler.removeMessages(WebCoreThread.RESUME_PRIORITY); sWebCoreHandler.sendMessageAtFrontOfQueue(sWebCoreHandler .obtainMessage(WebCoreThread.RESUME_PRIORITY)); - if (core != null) { - synchronized (core) { - core.mDrawIsScheduled = false; - core.mDrawIsPaused = false; - if (DebugFlags.WEB_VIEW_CORE) Log.v(LOGTAG, "resumeUpdate"); - core.contentDraw(); - } - } } static void startCacheTransaction() { @@ -1778,9 +1756,7 @@ final class WebViewCore { } // only fire an event if this is our first request synchronized (this) { - if (mDrawIsPaused || mDrawIsScheduled) { - return; - } + if (mDrawIsScheduled) return; mDrawIsScheduled = true; mEventHub.sendMessage(Message.obtain(null, EventHub.WEBKIT_DRAW)); } |