summaryrefslogtreecommitdiffstats
path: root/core/java
diff options
context:
space:
mode:
authorJohn Reck <jreck@google.com>2011-11-10 17:33:24 -0800
committerJohn Reck <jreck@google.com>2011-11-10 17:33:24 -0800
commit9f9fac0ad227941950efd8d09617064e5d4a37be (patch)
treeb024753e40caec8740072cfd61d0fd24816e9276 /core/java
parent843e04d977fd348ed474da1d3c6a62e7dc837444 (diff)
downloadframeworks_base-9f9fac0ad227941950efd8d09617064e5d4a37be.zip
frameworks_base-9f9fac0ad227941950efd8d09617064e5d4a37be.tar.gz
frameworks_base-9f9fac0ad227941950efd8d09617064e5d4a37be.tar.bz2
Fix lastVisible/global rects
Bug: 5601629 References tend to always be equal to the things they are referencing, use copies instead. Change-Id: I0827878e91ef1fa6e0abe2d6499d55f4a211d890
Diffstat (limited to 'core/java')
-rw-r--r--core/java/android/webkit/WebView.java8
1 files changed, 4 insertions, 4 deletions
diff --git a/core/java/android/webkit/WebView.java b/core/java/android/webkit/WebView.java
index 03d6511..7249497 100644
--- a/core/java/android/webkit/WebView.java
+++ b/core/java/android/webkit/WebView.java
@@ -2861,8 +2861,8 @@ public class WebView extends AbsoluteLayout
}
// Used to avoid sending many visible rect messages.
- private Rect mLastVisibleRectSent;
- private Rect mLastGlobalRect;
+ private Rect mLastVisibleRectSent = new Rect();
+ private Rect mLastGlobalRect = new Rect();
private Rect mVisibleRect = new Rect();
private Rect mGlobalVisibleRect = new Rect();
private Point mScrollOffset = new Point();
@@ -2878,7 +2878,7 @@ public class WebView extends AbsoluteLayout
mWebViewCore.sendMessage(EventHub.SET_SCROLL_OFFSET,
nativeMoveGeneration(), mSendScrollEvent ? 1 : 0, mScrollOffset);
}
- mLastVisibleRectSent = mVisibleRect;
+ mLastVisibleRectSent.set(mVisibleRect);
mPrivateHandler.removeMessages(SWITCH_TO_LONGPRESS);
}
if (getGlobalVisibleRect(mGlobalVisibleRect)
@@ -2894,7 +2894,7 @@ public class WebView extends AbsoluteLayout
if (!mBlockWebkitViewMessages) {
mWebViewCore.sendMessage(EventHub.SET_GLOBAL_BOUNDS, mGlobalVisibleRect);
}
- mLastGlobalRect = mGlobalVisibleRect;
+ mLastGlobalRect.set(mGlobalVisibleRect);
}
return mVisibleRect;
}