summaryrefslogtreecommitdiffstats
path: root/core/java
diff options
context:
space:
mode:
authorPaul Miller <paulmiller@google.com>2015-06-05 11:23:03 -0700
committerPaul Miller <paulmiller@google.com>2015-06-09 11:48:01 -0700
commitc8694a082ab4870d9f148ac98a5e1b3b07d75cc0 (patch)
tree1776cc3aab0c111c6b07046fbec41426869286b8 /core/java
parent6c72febd3526cc460b62926302fbcde1d38d42e5 (diff)
downloadframeworks_base-c8694a082ab4870d9f148ac98a5e1b3b07d75cc0.zip
frameworks_base-c8694a082ab4870d9f148ac98a5e1b3b07d75cc0.tar.gz
frameworks_base-c8694a082ab4870d9f148ac98a5e1b3b07d75cc0.tar.bz2
Deprecate WebView scrollbar overlay API
Deprecate setHorizontalScrollbarOverlay, setVerticalScrollbarOverlay, overlayHorizontalScrollbar, and overlayVerticalScrollbar. They've been no-ops for years, ever since WebViewChromium. BUG:21642246 Change-Id: Ia1062c53fdbaa7a0d282ba79da733a6f3b9ac84f
Diffstat (limited to 'core/java')
-rw-r--r--core/java/android/webkit/WebView.java24
-rw-r--r--core/java/android/webkit/WebViewProvider.java4
2 files changed, 18 insertions, 10 deletions
diff --git a/core/java/android/webkit/WebView.java b/core/java/android/webkit/WebView.java
index 5080fcc..aa72eb3 100644
--- a/core/java/android/webkit/WebView.java
+++ b/core/java/android/webkit/WebView.java
@@ -611,41 +611,45 @@ public class WebView extends AbsoluteLayout
/**
* Specifies whether the horizontal scrollbar has overlay style.
*
+ * @deprecated This method has no effect.
* @param overlay true if horizontal scrollbar should have overlay style
*/
+ @Deprecated
public void setHorizontalScrollbarOverlay(boolean overlay) {
- checkThread();
- mProvider.setHorizontalScrollbarOverlay(overlay);
}
/**
* Specifies whether the vertical scrollbar has overlay style.
*
+ * @deprecated This method has no effect.
* @param overlay true if vertical scrollbar should have overlay style
*/
+ @Deprecated
public void setVerticalScrollbarOverlay(boolean overlay) {
- checkThread();
- mProvider.setVerticalScrollbarOverlay(overlay);
}
/**
* Gets whether horizontal scrollbar has overlay style.
*
- * @return true if horizontal scrollbar has overlay style
+ * @deprecated This method is now obsolete.
+ * @return true
*/
+ @Deprecated
public boolean overlayHorizontalScrollbar() {
- checkThread();
- return mProvider.overlayHorizontalScrollbar();
+ // The old implementation defaulted to true, so return true for consistency
+ return true;
}
/**
* Gets whether vertical scrollbar has overlay style.
*
- * @return true if vertical scrollbar has overlay style
+ * @deprecated This method is now obsolete.
+ * @return false
*/
+ @Deprecated
public boolean overlayVerticalScrollbar() {
- checkThread();
- return mProvider.overlayVerticalScrollbar();
+ // The old implementation defaulted to false, so return false for consistency
+ return false;
}
/**
diff --git a/core/java/android/webkit/WebViewProvider.java b/core/java/android/webkit/WebViewProvider.java
index 09afcf1..27033ad 100644
--- a/core/java/android/webkit/WebViewProvider.java
+++ b/core/java/android/webkit/WebViewProvider.java
@@ -70,12 +70,16 @@ public interface WebViewProvider {
public void init(Map<String, Object> javaScriptInterfaces,
boolean privateBrowsing);
+ // Deprecated - should never be called
public void setHorizontalScrollbarOverlay(boolean overlay);
+ // Deprecated - should never be called
public void setVerticalScrollbarOverlay(boolean overlay);
+ // Deprecated - should never be called
public boolean overlayHorizontalScrollbar();
+ // Deprecated - should never be called
public boolean overlayVerticalScrollbar();
public int getVisibleTitleHeight();