diff options
author | George Mount <mount@google.com> | 2014-08-24 18:11:05 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2014-08-24 18:11:07 +0000 |
commit | da604cc1ec13cd0c6faf982b6dc9b69163664725 (patch) | |
tree | d34469d63c2261e37223b3f396b3ecd07f9022a5 /core/java | |
parent | a2c1449bb7cb46d5d5610f2c66b6a1ffa0d3d033 (diff) | |
parent | 448bace8612b0f9a41844339ca5db1b8eac1ac5c (diff) | |
download | frameworks_base-da604cc1ec13cd0c6faf982b6dc9b69163664725.zip frameworks_base-da604cc1ec13cd0c6faf982b6dc9b69163664725.tar.gz frameworks_base-da604cc1ec13cd0c6faf982b6dc9b69163664725.tar.bz2 |
Merge "API Review: change fragment transition methods." into lmp-dev
Diffstat (limited to 'core/java')
-rw-r--r-- | core/java/android/app/BackStackRecord.java | 18 | ||||
-rw-r--r-- | core/java/android/app/FragmentTransaction.java | 13 |
2 files changed, 26 insertions, 5 deletions
diff --git a/core/java/android/app/BackStackRecord.java b/core/java/android/app/BackStackRecord.java index 4433a3a..67863a5 100644 --- a/core/java/android/app/BackStackRecord.java +++ b/core/java/android/app/BackStackRecord.java @@ -580,6 +580,23 @@ final class BackStackRecord extends FragmentTransaction implements } @Override + public FragmentTransaction addSharedElement(View sharedElement, String name) { + String transitionName = sharedElement.getTransitionName(); + if (transitionName == null) { + throw new IllegalArgumentException("Unique transitionNames are required for all" + + " sharedElements"); + } + if (mSharedElementSourceNames == null) { + mSharedElementSourceNames = new ArrayList<String>(); + mSharedElementTargetNames = new ArrayList<String>(); + } + mSharedElementSourceNames.add(transitionName); + mSharedElementTargetNames.add(name); + return this; + } + + /** TODO: remove this */ + @Override public FragmentTransaction setSharedElement(View sharedElement, String name) { String transitionName = sharedElement.getTransitionName(); if (transitionName == null) { @@ -594,6 +611,7 @@ final class BackStackRecord extends FragmentTransaction implements return this; } + /** TODO: remove this */ @Override public FragmentTransaction setSharedElements(Pair<View, String>... sharedElements) { if (sharedElements == null || sharedElements.length == 0) { diff --git a/core/java/android/app/FragmentTransaction.java b/core/java/android/app/FragmentTransaction.java index 0adc835..1077bac 100644 --- a/core/java/android/app/FragmentTransaction.java +++ b/core/java/android/app/FragmentTransaction.java @@ -190,14 +190,17 @@ public abstract class FragmentTransaction { * @param name The transitionName for a View in an appearing Fragment to match to the shared * element. */ + public abstract FragmentTransaction addSharedElement(View sharedElement, String name); + + /** + * TODO: remove from API + * @hide + */ public abstract FragmentTransaction setSharedElement(View sharedElement, String name); /** - * Used with {@link #setCustomTransition(int, int)} to map multiple Views from removed or hidden - * Fragments to a Views from a shown or added Fragments. Views in - * <var>sharedElements</var> must have unique transitionNames in the View hierarchy. - * @param sharedElements Pairs of Views in disappearing Fragments to transitionNames in - * appearing Fragments. + * TODO: remove from API + * @hide */ public abstract FragmentTransaction setSharedElements(Pair<View, String>... sharedElements); |