summaryrefslogtreecommitdiffstats
path: root/core/res
diff options
context:
space:
mode:
authorAdam Powell <adamp@google.com>2011-10-03 12:08:54 -0700
committerAdam Powell <adamp@google.com>2011-10-03 13:20:23 -0700
commitf8419a0299680ed580975b0fcb758990b4367db8 (patch)
tree12c7967c3827ee44c4a4fe6542eb7f2d9e8ac9c7 /core/res
parent1401935b8f249fc56cd8fd236b3e0b4c46adae8d (diff)
downloadframeworks_base-f8419a0299680ed580975b0fcb758990b4367db8.zip
frameworks_base-f8419a0299680ed580975b0fcb758990b4367db8.tar.gz
frameworks_base-f8419a0299680ed580975b0fcb758990b4367db8.tar.bz2
Fix bugs around overlay action modes.
Multiple focusable windows cause undesired behavior around selection modes. TextView isn't sure how to behave when it loses window focus with regard to selection handles and action modes need to be focusable for WebView find on page since it uses an EditText as a custom view. For now: * Use a layered window decor for overlay action mode when there is no action bar requested. This eliminates an extra window and avoids the issue described for full-screen UIs. * Disable WebView's find-on-page mode when the action mode's UI will not be focusable. This only affects WebViews in floating windows. Also remove the "Text Selection" title for WebView's selection mode at UX's request, as it is inconsistent with TextView's selection mode and the string does not fit on phones in portrait even on wide devices. This now uses the same mechanism used in TextView to decide whether to use title text. Change-Id: I80caeecea9b47728cf26bb0a388153ca0bdeafe1
Diffstat (limited to 'core/res')
-rw-r--r--core/res/res/layout/screen_simple_overlay_action_mode.xml37
1 files changed, 37 insertions, 0 deletions
diff --git a/core/res/res/layout/screen_simple_overlay_action_mode.xml b/core/res/res/layout/screen_simple_overlay_action_mode.xml
new file mode 100644
index 0000000..eb093e7
--- /dev/null
+++ b/core/res/res/layout/screen_simple_overlay_action_mode.xml
@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+/*
+** Copyright 2011, The Android Open Source Project
+**
+** Licensed under the Apache License, Version 2.0 (the "License");
+** you may not use this file except in compliance with the License.
+** You may obtain a copy of the License at
+**
+** http://www.apache.org/licenses/LICENSE-2.0
+**
+** Unless required by applicable law or agreed to in writing, software
+** distributed under the License is distributed on an "AS IS" BASIS,
+** WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+** See the License for the specific language governing permissions and
+** limitations under the License.
+*/
+
+This is an optimized layout for a screen, with the minimum set of features
+enabled.
+-->
+
+<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ android:fitsSystemWindows="true">
+ <FrameLayout
+ android:id="@android:id/content"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:foregroundInsidePadding="false"
+ android:foregroundGravity="fill_horizontal|top"
+ android:foreground="?android:attr/windowContentOverlay" />
+ <ViewStub android:id="@+id/action_mode_bar_stub"
+ android:inflatedId="@+id/action_mode_bar"
+ android:layout="@layout/action_mode_bar"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content" />
+</FrameLayout>