diff options
author | Makoto Onuki <omakoto@google.com> | 2015-06-25 11:56:44 -0700 |
---|---|---|
committer | Makoto Onuki <omakoto@google.com> | 2015-06-25 14:46:25 -0700 |
commit | c7a14e442dcab7efd89af1bc671e6869904d19f6 (patch) | |
tree | 98022523925a0adb668f673b6ec5db13bebadc59 /core/tests/coretests | |
parent | 323b768d6d06c73209363f559cdd278e06ca7e48 (diff) | |
download | frameworks_base-c7a14e442dcab7efd89af1bc671e6869904d19f6.zip frameworks_base-c7a14e442dcab7efd89af1bc671e6869904d19f6.tar.gz frameworks_base-c7a14e442dcab7efd89af1bc671e6869904d19f6.tar.bz2 |
Fix Formatter.formatBytes() crash on non-EN locales
Bug 22012651
Change-Id: I21b1834a35647527002e01d76a7eb3a6a0354512
Diffstat (limited to 'core/tests/coretests')
-rw-r--r-- | core/tests/coretests/src/android/text/format/FormatterTest.java | 104 |
1 files changed, 104 insertions, 0 deletions
diff --git a/core/tests/coretests/src/android/text/format/FormatterTest.java b/core/tests/coretests/src/android/text/format/FormatterTest.java new file mode 100644 index 0000000..d2e2131 --- /dev/null +++ b/core/tests/coretests/src/android/text/format/FormatterTest.java @@ -0,0 +1,104 @@ +/* + * Copyright (C) 2015 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.text.format; + +import android.content.res.Configuration; +import android.content.res.Resources; +import android.test.AndroidTestCase; +import android.test.suitebuilder.annotation.SmallTest; +import android.text.format.Formatter.BytesResult; + +import java.util.Locale; + +public class FormatterTest extends AndroidTestCase { + + private Locale mOriginalLocale; + + @Override + protected void setUp() throws Exception { + super.setUp(); + + mOriginalLocale = mContext.getResources().getConfiguration().locale; + } + + @Override + protected void tearDown() throws Exception { + if (mOriginalLocale != null) { + setLocale(mOriginalLocale); + } + super.tearDown(); + } + + private void setLocale(Locale locale) { + Resources res = getContext().getResources(); + Configuration config = res.getConfiguration(); + config.locale = locale; + res.updateConfiguration(config, res.getDisplayMetrics()); + + Locale.setDefault(locale); + } + + @SmallTest + public void testFormatBytes() { + setLocale(Locale.ENGLISH); + + checkFormatBytes(0, true, "0.00", 0); + checkFormatBytes(0, false, "0.00", 0); + + checkFormatBytes(1, true, "1.0", 1); + checkFormatBytes(1, false, "1.00", 1); + + checkFormatBytes(12, true, "12", 12); + checkFormatBytes(12, false, "12.00", 12); + + checkFormatBytes(123, true, "123", 123); + checkFormatBytes(123, false, "123", 123); + + checkFormatBytes(812, true, "812", 812); + checkFormatBytes(812, false, "812", 812); + + checkFormatBytes(912, true, "0.89", 911); + checkFormatBytes(912, false, "0.89", 911); + + checkFormatBytes(9123, true, "8.9", 9113); + checkFormatBytes(9123, false, "8.91", 9123); + + checkFormatBytes(9123000, true, "8.7", 9122611); + checkFormatBytes(9123000, false, "8.70", 9122611); + + // The method doesn't really support negative values, but apparently people pass -1... + checkFormatBytes(-1, true, "-1.00", -1); + checkFormatBytes(-1, false, "-1.00", -1); + + // Missing FLAG_CALCULATE_ROUNDED case. + BytesResult r = Formatter.formatBytes(getContext().getResources(), 1, 0); + assertEquals("1.00", r.value); + assertEquals(0, r.roundedBytes); // Didn't pass FLAG_CALCULATE_ROUNDED + + // Make sure it works on different locales. + setLocale(new Locale("es", "ES")); + checkFormatBytes(9123000, false, "8,70", 9122611); + } + + private void checkFormatBytes(long bytes, boolean useShort, + String expectedString, long expectedRounded) { + BytesResult r = Formatter.formatBytes(getContext().getResources(), bytes, + Formatter.FLAG_CALCULATE_ROUNDED | (useShort ? Formatter.FLAG_SHORTER : 0)); + assertEquals(expectedString, r.value); + assertEquals(expectedRounded, r.roundedBytes); + } +} |