summaryrefslogtreecommitdiffstats
path: root/core
diff options
context:
space:
mode:
authorKenny Root <kroot@google.com>2010-07-30 16:52:29 -0700
committerKenny Root <kroot@google.com>2010-08-02 07:52:56 -0700
commit930d3af75f9e9663222f4c4a1d75b326cf811e35 (patch)
tree30950867a1eec93131934190d0faae893cacd4e3 /core
parent7c600369c9695de73ca37db552eb81b8b89d5e76 (diff)
downloadframeworks_base-930d3af75f9e9663222f4c4a1d75b326cf811e35.zip
frameworks_base-930d3af75f9e9663222f4c4a1d75b326cf811e35.tar.gz
frameworks_base-930d3af75f9e9663222f4c4a1d75b326cf811e35.tar.bz2
Do not deference before null check
The return of parsePackageLite wasn't checked until after it was deferenced. Move the deference below the null check and remove redundant set. Bug: 2852726 Change-Id: I3eaaea5050948145eed44b64507dc846993d98eb
Diffstat (limited to 'core')
-rw-r--r--core/java/android/content/pm/PackageParser.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/core/java/android/content/pm/PackageParser.java b/core/java/android/content/pm/PackageParser.java
index 73c4011..0b35d8b 100644
--- a/core/java/android/content/pm/PackageParser.java
+++ b/core/java/android/content/pm/PackageParser.java
@@ -587,7 +587,7 @@ public class PackageParser {
* location from the apk location at the given file path.
* @param packageFilePath file location of the apk
* @param flags Special parse flags
- * @return PackageLite object with package information.
+ * @return PackageLite object with package information or null on failure.
*/
public static PackageLite parsePackageLite(String packageFilePath, int flags) {
XmlResourceParser parser = null;