diff options
author | android-build SharedAccount <android-build@google.com> | 2010-11-18 10:52:41 -0800 |
---|---|---|
committer | android-build SharedAccount <android-build@google.com> | 2010-11-18 10:52:41 -0800 |
commit | 8b8914b50d36734305d582485fa839b7d04b8872 (patch) | |
tree | 8a0e551e7a7f1884fcc87aa4dc12e42bde0162f4 /core | |
parent | 7200ab4a8f61b4aed25f9536ae29051e02503563 (diff) | |
download | frameworks_base-8b8914b50d36734305d582485fa839b7d04b8872.zip frameworks_base-8b8914b50d36734305d582485fa839b7d04b8872.tar.gz frameworks_base-8b8914b50d36734305d582485fa839b7d04b8872.tar.bz2 |
Temp fix; Revert "Fix bug 3167081 - Action Bar redesign to support "up""
This reverts commit 432e5f9f167e622d03fee0e10215b6e2234c1a3c.
Conflicts:
core/res/res/values/public.xml
Change-Id: I7212626479da7aef80b9bcb4c2144435364dafae
Diffstat (limited to 'core')
19 files changed, 68 insertions, 68 deletions
diff --git a/core/java/com/android/internal/widget/ActionBarView.java b/core/java/com/android/internal/widget/ActionBarView.java index b382cee..e18f58f 100644 --- a/core/java/com/android/internal/widget/ActionBarView.java +++ b/core/java/com/android/internal/widget/ActionBarView.java @@ -82,10 +82,12 @@ public class ActionBarView extends ViewGroup { private Drawable mIcon; private Drawable mLogo; private Drawable mDivider; + private Drawable mHomeAsUpIndicator; - private View mHomeLayout; - private View mHomeAsUpView; + private LinearLayout mHomeLayout; + private ImageView mHomeAsUpView; private ImageView mIconView; + private ImageView mLogoView; private LinearLayout mTitleLayout; private TextView mTitleView; private TextView mSubtitleView; @@ -170,15 +172,18 @@ public class ActionBarView extends ViewGroup { } } - final LayoutInflater inflater = LayoutInflater.from(context); + mHomeLayout = new LinearLayout(context, null, + com.android.internal.R.attr.actionButtonStyle); + mHomeLayout.setLayoutParams(new LayoutParams(LayoutParams.WRAP_CONTENT, + LayoutParams.MATCH_PARENT)); - final int homeResId = a.getResourceId( - com.android.internal.R.styleable.ActionBar_homeLayout, 0); + mHomeAsUpIndicator = a.getDrawable(R.styleable.ActionBar_homeAsUpIndicator); - mHomeLayout = inflater.inflate(homeResId, this, false); - - mHomeAsUpView = mHomeLayout.findViewById(com.android.internal.R.id.up); - mIconView = (ImageView) mHomeLayout.findViewById(com.android.internal.R.id.home); + mHomeAsUpView = new ImageView(context); + mHomeAsUpView.setImageDrawable(mHomeAsUpIndicator); + mHomeAsUpView.setLayoutParams(new LayoutParams(LayoutParams.WRAP_CONTENT, + LayoutParams.MATCH_PARENT)); + mHomeLayout.addView(mHomeAsUpView); Drawable background = a.getDrawable(R.styleable.ActionBar_background); if (background != null) { @@ -197,7 +202,8 @@ public class ActionBarView extends ViewGroup { final int customNavId = a.getResourceId(R.styleable.ActionBar_customNavigationLayout, 0); if (customNavId != 0) { - mCustomNavView = (View) inflater.inflate(customNavId, this, false); + LayoutInflater inflater = LayoutInflater.from(context); + mCustomNavView = (View) inflater.inflate(customNavId, null); mNavigationMode = ActionBar.NAVIGATION_MODE_STANDARD; setDisplayOptions(mDisplayOptions | ActionBar.DISPLAY_SHOW_CUSTOM); } @@ -369,12 +375,13 @@ public class ActionBarView extends ViewGroup { if ((flagsChanged & ActionBar.DISPLAY_HOME_AS_UP) != 0) { mHomeAsUpView.setVisibility((options & ActionBar.DISPLAY_HOME_AS_UP) != 0 - ? VISIBLE : INVISIBLE); + ? VISIBLE : GONE); } - if ((flagsChanged & ActionBar.DISPLAY_USE_LOGO) != 0) { - final boolean logoVis = mLogo != null && (options & ActionBar.DISPLAY_USE_LOGO) != 0; - mIconView.setImageDrawable(logoVis ? mLogo : mIcon); + if (mLogoView != null && (flagsChanged & ActionBar.DISPLAY_USE_LOGO) != 0) { + final boolean logoVis = (options & ActionBar.DISPLAY_USE_LOGO) != 0; + mLogoView.setVisibility(logoVis ? VISIBLE : GONE); + mIconView.setVisibility(logoVis ? GONE : VISIBLE); } if ((flagsChanged & ActionBar.DISPLAY_SHOW_TITLE) != 0) { @@ -524,8 +531,50 @@ public class ActionBarView extends ViewGroup { protected void onFinishInflate() { super.onFinishInflate(); + final Context context = getContext(); + + if (mLogo != null) { + mLogoView = new ImageView(context); + mLogoView.setScaleType(ImageView.ScaleType.CENTER); + mLogoView.setLayoutParams(new LayoutParams(LayoutParams.WRAP_CONTENT, + LayoutParams.MATCH_PARENT)); + mLogoView.setImageDrawable(mLogo); + mLogoView.setVisibility((mDisplayOptions & ActionBar.DISPLAY_USE_LOGO) != 0 + ? VISIBLE : GONE); + mHomeLayout.addView(mLogoView); + } + + if (mIcon != null) { + mIconView = new ImageView(context, null, + com.android.internal.R.attr.actionButtonStyle); + mIconView.setScaleType(ImageView.ScaleType.CENTER); + mIconView.setLayoutParams(new LayoutParams(LayoutParams.WRAP_CONTENT, + LayoutParams.MATCH_PARENT)); + mIconView.setImageDrawable(mIcon); + mIconView.setVisibility( + (mDisplayOptions & ActionBar.DISPLAY_USE_LOGO) == 0 || mLogo == null + ? VISIBLE : GONE); + mHomeLayout.addView(mIconView); + } + addView(mHomeLayout); + switch (mNavigationMode) { + case ActionBar.NAVIGATION_MODE_STANDARD: + if (mLogoView == null) { + initTitle(); + } + break; + + case ActionBar.NAVIGATION_MODE_LIST: + throw new UnsupportedOperationException( + "Inflating list navigation isn't supported yet!"); + + case ActionBar.NAVIGATION_MODE_TABS: + throw new UnsupportedOperationException( + "Inflating tab navigation isn't supported yet!"); + } + if (mCustomNavView != null && (mDisplayOptions & ActionBar.DISPLAY_SHOW_CUSTOM) != 0) { final ViewParent parent = mCustomNavView.getParent(); if (parent != this) { @@ -604,11 +653,8 @@ public class ActionBarView extends ViewGroup { int rightOfCenter = leftOfCenter; if (mHomeLayout.getVisibility() != GONE) { - mHomeLayout.measure(MeasureSpec.makeMeasureSpec(availableWidth, MeasureSpec.AT_MOST), - MeasureSpec.makeMeasureSpec(height, MeasureSpec.EXACTLY)); - final int homeWidth = mHomeLayout.getMeasuredWidth(); - availableWidth -= homeWidth; - leftOfCenter -= homeWidth; + availableWidth = measureChildView(mHomeLayout, availableWidth, childSpecHeight, 0); + leftOfCenter -= mHomeLayout.getMeasuredWidth(); } if (mMenuView != null) { diff --git a/core/res/res/drawable-hdpi/ic_ab_back_holo_dark.png b/core/res/res/drawable-hdpi/ic_ab_back_holo_dark.png Binary files differindex b4079db..a8da981 100644 --- a/core/res/res/drawable-hdpi/ic_ab_back_holo_dark.png +++ b/core/res/res/drawable-hdpi/ic_ab_back_holo_dark.png diff --git a/core/res/res/drawable-hdpi/ic_ab_back_holo_light.png b/core/res/res/drawable-hdpi/ic_ab_back_holo_light.png Binary files differindex 09e83e4..af0f308 100644 --- a/core/res/res/drawable-hdpi/ic_ab_back_holo_light.png +++ b/core/res/res/drawable-hdpi/ic_ab_back_holo_light.png diff --git a/core/res/res/drawable-hdpi/ic_menu_moreoverflow_focused_holo_dark.png b/core/res/res/drawable-hdpi/ic_menu_moreoverflow_focused_holo_dark.png Binary files differindex 3ecaa9d..061f80a 100644 --- a/core/res/res/drawable-hdpi/ic_menu_moreoverflow_focused_holo_dark.png +++ b/core/res/res/drawable-hdpi/ic_menu_moreoverflow_focused_holo_dark.png diff --git a/core/res/res/drawable-hdpi/ic_menu_moreoverflow_focused_holo_light.png b/core/res/res/drawable-hdpi/ic_menu_moreoverflow_focused_holo_light.png Binary files differindex 40009af..d818806 100644 --- a/core/res/res/drawable-hdpi/ic_menu_moreoverflow_focused_holo_light.png +++ b/core/res/res/drawable-hdpi/ic_menu_moreoverflow_focused_holo_light.png diff --git a/core/res/res/drawable-hdpi/ic_menu_moreoverflow_normal_holo_dark.png b/core/res/res/drawable-hdpi/ic_menu_moreoverflow_normal_holo_dark.png Binary files differindex e21f534..8563c1a 100644 --- a/core/res/res/drawable-hdpi/ic_menu_moreoverflow_normal_holo_dark.png +++ b/core/res/res/drawable-hdpi/ic_menu_moreoverflow_normal_holo_dark.png diff --git a/core/res/res/drawable-hdpi/ic_menu_moreoverflow_normal_holo_light.png b/core/res/res/drawable-hdpi/ic_menu_moreoverflow_normal_holo_light.png Binary files differindex 9108fa1..1cd2384 100644 --- a/core/res/res/drawable-hdpi/ic_menu_moreoverflow_normal_holo_light.png +++ b/core/res/res/drawable-hdpi/ic_menu_moreoverflow_normal_holo_light.png diff --git a/core/res/res/drawable-mdpi/ic_ab_back_holo_dark.png b/core/res/res/drawable-mdpi/ic_ab_back_holo_dark.png Binary files differindex 08a8eca..7aae741 100644 --- a/core/res/res/drawable-mdpi/ic_ab_back_holo_dark.png +++ b/core/res/res/drawable-mdpi/ic_ab_back_holo_dark.png diff --git a/core/res/res/drawable-mdpi/ic_ab_back_holo_light.png b/core/res/res/drawable-mdpi/ic_ab_back_holo_light.png Binary files differindex 0ffafd8..66ef51c 100644 --- a/core/res/res/drawable-mdpi/ic_ab_back_holo_light.png +++ b/core/res/res/drawable-mdpi/ic_ab_back_holo_light.png diff --git a/core/res/res/drawable-mdpi/ic_menu_moreoverflow_focused_holo_dark.png b/core/res/res/drawable-mdpi/ic_menu_moreoverflow_focused_holo_dark.png Binary files differindex c369e6f..6f87b11 100644 --- a/core/res/res/drawable-mdpi/ic_menu_moreoverflow_focused_holo_dark.png +++ b/core/res/res/drawable-mdpi/ic_menu_moreoverflow_focused_holo_dark.png diff --git a/core/res/res/drawable-mdpi/ic_menu_moreoverflow_focused_holo_light.png b/core/res/res/drawable-mdpi/ic_menu_moreoverflow_focused_holo_light.png Binary files differindex a4df2bf..04dac38 100644 --- a/core/res/res/drawable-mdpi/ic_menu_moreoverflow_focused_holo_light.png +++ b/core/res/res/drawable-mdpi/ic_menu_moreoverflow_focused_holo_light.png diff --git a/core/res/res/drawable-mdpi/ic_menu_moreoverflow_normal_holo_dark.png b/core/res/res/drawable-mdpi/ic_menu_moreoverflow_normal_holo_dark.png Binary files differindex a7389c9..5580af6 100644 --- a/core/res/res/drawable-mdpi/ic_menu_moreoverflow_normal_holo_dark.png +++ b/core/res/res/drawable-mdpi/ic_menu_moreoverflow_normal_holo_dark.png diff --git a/core/res/res/drawable-mdpi/ic_menu_moreoverflow_normal_holo_light.png b/core/res/res/drawable-mdpi/ic_menu_moreoverflow_normal_holo_light.png Binary files differindex 87e41ac..fc2081a 100644 --- a/core/res/res/drawable-mdpi/ic_menu_moreoverflow_normal_holo_light.png +++ b/core/res/res/drawable-mdpi/ic_menu_moreoverflow_normal_holo_light.png diff --git a/core/res/res/layout/action_bar_home.xml b/core/res/res/layout/action_bar_home.xml deleted file mode 100644 index e8b5637..0000000 --- a/core/res/res/layout/action_bar_home.xml +++ /dev/null @@ -1,34 +0,0 @@ -<?xml version="1.0" encoding="utf-8"?> -<!-- Copyright (C) 2010 The Android Open Source Project - - Licensed under the Apache License, Version 2.0 (the "License"); - you may not use this file except in compliance with the License. - You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, software - distributed under the License is distributed on an "AS IS" BASIS, - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - See the License for the specific language governing permissions and - limitations under the License. ---> - -<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android" - android:layout_width="wrap_content" - android:layout_height="match_parent" - android:background="?android:attr/selectableItemBackground"> - <ImageView android:id="@android:id/up" - android:src="?android:attr/homeAsUpIndicator" - android:layout_gravity="top|left" - android:visibility="invisible" - android:layout_width="wrap_content" - android:layout_height="wrap_content" /> - <ImageView android:id="@android:id/home" - android:layout_width="wrap_content" - android:layout_height="match_parent" - android:paddingLeft="16dip" - android:paddingRight="16dip" - android:layout_gravity="center" - android:scaleType="center" /> -</FrameLayout> diff --git a/core/res/res/values/attrs.xml b/core/res/res/values/attrs.xml index 651bfea..9d54a80 100755 --- a/core/res/res/values/attrs.xml +++ b/core/res/res/values/attrs.xml @@ -607,9 +607,6 @@ <!-- SearchView dropdown background --> <attr name="searchDropdownBackground" format="reference" /> - - <!-- Specifies a drawable to use for the 'home as up' indicator. --> - <attr name="homeAsUpIndicator" format="reference" /> </declare-styleable> <!-- **************************************************************** --> @@ -4413,8 +4410,8 @@ <attr name="customNavigationLayout" format="reference" /> <!-- Specifies a fixed height. --> <attr name="height" /> - <!-- Specifies a layout to use for the "home" section of the action bar. --> - <attr name="homeLayout" format="reference" /> + <!-- Specifies a drawable to use for the 'home as up' indicator. --> + <attr name="homeAsUpIndicator" format="reference" /> <!-- Specifies a style resource to use for an embedded progress bar. --> <attr name="progressBarStyle" /> <!-- Specifies a style resource to use for an indeterminate progress spinner. --> diff --git a/core/res/res/values/ids.xml b/core/res/res/values/ids.xml index 7a0fede..b7f177f 100644 --- a/core/res/res/values/ids.xml +++ b/core/res/res/values/ids.xml @@ -72,5 +72,4 @@ <item type="id" name="home" /> <item type="id" name="fillInIntent" /> <item type="id" name="rowTypeId" /> - <item type="id" name="up" /> </resources> diff --git a/core/res/res/values/public.xml b/core/res/res/values/public.xml index e319fa0..aa33aa3 100644 --- a/core/res/res/values/public.xml +++ b/core/res/res/values/public.xml @@ -1377,7 +1377,6 @@ <public type="attr" name="animationResolution" /> <public type="attr" name="state_accelerated" /> <public type="attr" name="baseline" /> - <public type="attr" name="homeLayout" /> <public type="attr" name="opacity" /> <public type="anim" name="animator_fade_in" /> @@ -1396,7 +1395,6 @@ <!-- Context menu ID for the "Select text..." menu item to switch to text selection context mode in text views. --> <public type="id" name="selectTextMode" /> - <public type="id" name="up" /> <!-- Standard content view for a {@link android.app.ListFragment}. If you are implementing a subclass of ListFragment with your diff --git a/core/res/res/values/styles.xml b/core/res/res/values/styles.xml index 457ba0c..dc67f45 100644 --- a/core/res/res/values/styles.xml +++ b/core/res/res/values/styles.xml @@ -917,7 +917,6 @@ <item name="android:subtitleTextStyle">@android:style/TextAppearance.Widget.ActionBar.Subtitle</item> <item name="android:progressBarStyle">@android:style/Widget.ProgressBar.Horizontal</item> <item name="android:indeterminateProgressStyle">@android:style/Widget.ProgressBar.Small</item> - <item name="android:homeLayout">@layout/action_bar_home</item> </style> <style name="Widget.ActionMode"> @@ -1509,8 +1508,6 @@ <style name="Widget.Holo.ActionButton.Overflow"> <item name="android:src">@android:drawable/ic_menu_moreoverflow_holo_dark</item> <item name="android:background">?android:attr/selectableItemBackground</item> - <item name="android:paddingLeft">16dip</item> - <item name="android:paddingRight">16dip</item> </style> <style name="Widget.Holo.ActionButton.TextButton" parent="Widget.Holo.ButtonBar.Button"> @@ -1543,6 +1540,7 @@ <item name="android:subtitleTextStyle">@android:style/TextAppearance.Holo.Widget.ActionBar.Subtitle</item> <item name="android:background">@null</item> <item name="android:divider">?android:attr/dividerVertical</item> + <item name="android:homeAsUpIndicator">@android:drawable/ic_ab_back_holo_dark</item> <item name="android:progressBarStyle">@android:style/Widget.Holo.ProgressBar.Horizontal</item> <item name="android:indeterminateProgressStyle">@android:style/Widget.Holo.ProgressBar</item> <item name="android:progressBarPadding">32dip</item> @@ -1775,8 +1773,6 @@ <style name="Widget.Holo.Light.ActionButton.Overflow"> <item name="android:src">@android:drawable/ic_menu_moreoverflow_holo_light</item> <item name="android:background">?android:attr/selectableItemBackground</item> - <item name="android:paddingLeft">16dip</item> - <item name="android:paddingRight">16dip</item> </style> <style name="Widget.Holo.Light.ActionBarView_TabView" parent="Widget.ActionBarView_TabView"> diff --git a/core/res/res/values/themes.xml b/core/res/res/values/themes.xml index b5dcf05..a409c24 100644 --- a/core/res/res/values/themes.xml +++ b/core/res/res/values/themes.xml @@ -706,7 +706,6 @@ <item name="groupButtonBackground">@android:drawable/group_button_background_holo_dark</item> <item name="selectableItemBackground">@android:drawable/item_background_holo_dark</item> - <item name="homeAsUpIndicator">@android:drawable/ic_ab_back_holo_dark</item> <!-- List attributes --> <item name="listPreferredItemHeight">64dip</item> @@ -943,7 +942,6 @@ <item name="groupButtonBackground">@android:drawable/group_button_background_holo_light</item> <item name="selectableItemBackground">@android:drawable/item_background_holo_light</item> - <item name="homeAsUpIndicator">@android:drawable/ic_ab_back_holo_light</item> <!-- List attributes --> <item name="listPreferredItemHeight">64dip</item> |