summaryrefslogtreecommitdiffstats
path: root/core
diff options
context:
space:
mode:
authorJohn Reck <jreck@google.com>2014-04-11 08:54:47 -0700
committerJohn Reck <jreck@google.com>2014-04-11 12:57:53 -0700
commitf7483e3af0513a1baa8341d403df2e0c0896a9ff (patch)
tree1e528710efbfe016882e4e389c2c647a9c4a78b3 /core
parent23d2dd3da15b4312cc55c4d7b0bcf70719655e65 (diff)
downloadframeworks_base-f7483e3af0513a1baa8341d403df2e0c0896a9ff.zip
frameworks_base-f7483e3af0513a1baa8341d403df2e0c0896a9ff.tar.gz
frameworks_base-f7483e3af0513a1baa8341d403df2e0c0896a9ff.tar.bz2
Simplify matrix calculations
Bug: 13913604 Change-Id: I2c0f85a34e1e520050a5a6131306d6b7c352d827
Diffstat (limited to 'core')
-rw-r--r--core/java/android/view/View.java6
-rw-r--r--core/jni/android_view_RenderNode.cpp8
2 files changed, 3 insertions, 11 deletions
diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java
index 9761f1a..0196ca1 100644
--- a/core/java/android/view/View.java
+++ b/core/java/android/view/View.java
@@ -2968,12 +2968,6 @@ public class View implements Drawable.Callback, KeyEvent.Callback,
private boolean mLastIsOpaque;
/**
- * Convenience value to check for float values that are close enough to zero to be considered
- * zero.
- */
- private static final float NONZERO_EPSILON = .001f;
-
- /**
* The distance in pixels from the left edge of this view's parent
* to the left edge of this view.
* {@hide}
diff --git a/core/jni/android_view_RenderNode.cpp b/core/jni/android_view_RenderNode.cpp
index 31a1de6..8dacfeb 100644
--- a/core/jni/android_view_RenderNode.cpp
+++ b/core/jni/android_view_RenderNode.cpp
@@ -376,7 +376,8 @@ static jboolean android_view_RenderNode_isPivotExplicitlySet(JNIEnv* env,
static jboolean android_view_RenderNode_hasIdentityMatrix(JNIEnv* env,
jobject clazz, jlong renderNodePtr) {
RenderNode* renderNode = reinterpret_cast<RenderNode*>(renderNodePtr);
- return renderNode->stagingProperties().getMatrixFlags() == 0;
+ renderNode->mutateStagingProperties().updateMatrix();
+ return !renderNode->stagingProperties().hasTransformMatrix();
}
// ----------------------------------------------------------------------------
@@ -391,10 +392,7 @@ static void android_view_RenderNode_getTransformMatrix(JNIEnv* env,
renderNode->mutateStagingProperties().updateMatrix();
const SkMatrix* transformMatrix = renderNode->stagingProperties().getTransformMatrix();
- if (renderNode->stagingProperties().getMatrixFlags() == TRANSLATION) {
- outMatrix->setTranslate(renderNode->stagingProperties().getTranslationX(),
- renderNode->stagingProperties().getTranslationY());
- } else if (transformMatrix) {
+ if (transformMatrix) {
*outMatrix = *transformMatrix;
} else {
outMatrix->setIdentity();