diff options
| author | Jeff Brown <jeffbrown@google.com> | 2011-01-25 16:02:22 -0800 |
|---|---|---|
| committer | Jeff Brown <jeffbrown@google.com> | 2011-01-25 16:02:22 -0800 |
| commit | 58a2da843f2f22f406df8df1f011738eb8b7fcb1 (patch) | |
| tree | 716c12630d5d9fe98e29e197287dc950eaa4a01c /include/ui | |
| parent | 30bc34f191ca8a009af313fc751e5b4bff6e39a1 (diff) | |
| download | frameworks_base-58a2da843f2f22f406df8df1f011738eb8b7fcb1.zip frameworks_base-58a2da843f2f22f406df8df1f011738eb8b7fcb1.tar.gz frameworks_base-58a2da843f2f22f406df8df1f011738eb8b7fcb1.tar.bz2 | |
Fix crashes caused by some input devices.
The touch screen sometimes reports more than 10 pointers even though that's
all we asked for. When this happens, we start dropping events with more
than 10 pointers. This confuses applications and causes them to crash.
Raised the limit to 16 pointers.
Bug: 3331247
The default behavior was to identify all touch devices as touch screens.
External devices that are plugged in are more likely to be touch pads
not attached to a screen. Changed the default to be a touch pad
and renamed some internal constants to avoid confusion.
A certain mouse happens to also behave like a touch pad. That caused
problems because we would see multiple concurrent traces of motion events
coming from the same input device so we would batch them up.
Added code to ensure that we don't batch events unless they come from
the same *source* in addition to coming from the same *device*.
Due to batching or misbehaving drivers, it's possible for the set of
pointer ids to be different from what we expect when it comes time to
split motion events across windows. As a result, we can generate motion
events with 0 pointers. When we try to deliver those events, we cause
an error in the InputTransport so we tear down the InputChannel and kill
the application.
Added code to check out assumption about pointer ids and drop the
event gracefully instead.
Patched up the tests to take into account the change in default behavior
for identifying touch screens and touch pads.
Change-Id: Ic364bd4cb4cc6335d4a1213a26d6bdadc7e33505
Diffstat (limited to 'include/ui')
| -rw-r--r-- | include/ui/Input.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/include/ui/Input.h b/include/ui/Input.h index 30b45f7..2012fcc 100644 --- a/include/ui/Input.h +++ b/include/ui/Input.h @@ -50,8 +50,10 @@ enum { /* * Maximum number of pointers supported per motion event. * Smallest number of pointers is 1. + * (We want at least 10 but some touch controllers obstensibly configured for 10 pointers + * will occasionally emit 11. There is not much harm making this constant bigger.) */ -#define MAX_POINTERS 10 +#define MAX_POINTERS 16 /* * Maximum pointer id value supported in a motion event. |