diff options
| author | Christopher Tate <ctate@google.com> | 2015-03-24 18:48:10 -0700 |
|---|---|---|
| committer | Christopher Tate <ctate@google.com> | 2015-03-26 18:57:36 -0700 |
| commit | 11ae768cf1b8348e761ad9c09e98788da1e591b1 (patch) | |
| tree | fa4a4e9fffc83e61af98476d41df4252e3cd1323 /include | |
| parent | e7f931c4505a6bd62e01bef5193dd724571a672b (diff) | |
| download | frameworks_base-11ae768cf1b8348e761ad9c09e98788da1e591b1.zip frameworks_base-11ae768cf1b8348e761ad9c09e98788da1e591b1.tar.gz frameworks_base-11ae768cf1b8348e761ad9c09e98788da1e591b1.tar.bz2 | |
Add payload-size preflight stage to full transport backup
We now peform a total-size preflight pass before committing data to the
wire. This is to eliminate the large superfluous network traffic that
would otherwise happen if the transport enforces internal quotas: we
now instead ask the transport up front whether it's prepared to accept
a given payload size for the package.
From the app's perspective this preflight operation is indistinguishable
from a full-data backup pass. If the app has provided its own full-data
handling in a subclassed backup agent, their usual file-providing code
path will be executed. However, the files named for backup during this
pass are not opened and read; just measured for their total size. As
far as component lifecycles, this measurement pass is simply another
call to the agent, immediately after it is bound, with identical
timeout semantics to the existing full-data backup invocation.
Once the app's file set has been measured the preflight operation
invokes a new method on BackupTransport, called checkFullBackupSize().
This method is called after performFullBackup() (which applies any
overall whitelist/blacklist policy) but before any data is delivered
to the transport via sendBackupData(). The return code from
checkFullBackupSize() is similar to the other transport methods:
TRANSPORT_OK to permit the full backup to proceed; or
TRANSPORT_REJECT_PACKAGE to indicate that the requested payload is
unacceptable; or TRANSPORT_ERROR to report a more serious overall
transport-level problem that prevents a full-data backup operation
from occurring right now.
The estimated payload currently does not include the size of the
source-package metadata (technically, the manifest entry in its
archive payload) or the size of any widget metadata associated with
the package's install. In practice this means the preflighted size
underestimates by 3 to 5 KB. In addition, the preflight API currently
cannot distinguish between payload sizes larger than 2 gigabytes;
any payload estimate larger than that is passed as Integer.MAX_VALUE
to the checkFullBackupSize() query.
Bug 19846750
Change-Id: I44498201e2d4b07482dcb3ca8fa6935dddc467ca
Diffstat (limited to 'include')
| -rw-r--r-- | include/androidfw/BackupHelpers.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/include/androidfw/BackupHelpers.h b/include/androidfw/BackupHelpers.h index 0841af6..fc1ad47 100644 --- a/include/androidfw/BackupHelpers.h +++ b/include/androidfw/BackupHelpers.h @@ -17,6 +17,8 @@ #ifndef _UTILS_BACKUP_HELPERS_H #define _UTILS_BACKUP_HELPERS_H +#include <sys/stat.h> + #include <utils/Errors.h> #include <utils/String8.h> #include <utils/KeyedVector.h> @@ -135,7 +137,8 @@ int back_up_files(int oldSnapshotFD, BackupDataWriter* dataStream, int newSnapsh char const* const* files, char const* const *keys, int fileCount); int write_tarfile(const String8& packageName, const String8& domain, - const String8& rootPath, const String8& filePath, BackupDataWriter* outputStream); + const String8& rootPath, const String8& filePath, off_t* outSize, + BackupDataWriter* outputStream); class RestoreHelperBase { |