diff options
| author | Tom Hudson <tomhudson@google.com> | 2015-03-30 15:59:02 -0400 |
|---|---|---|
| committer | Tom Hudson <tomhudson@google.com> | 2015-03-30 16:57:43 -0400 |
| commit | e30b53cec5eb6eaa5d24231feb3207b917c1baab (patch) | |
| tree | 386c65cec91fa48e12cec5b46bf0f6795bc094a2 /libs/hwui/ClipArea.h | |
| parent | b13f44bc6ee65e155c54f645ab4aa6786feeb162 (diff) | |
| download | frameworks_base-e30b53cec5eb6eaa5d24231feb3207b917c1baab.zip frameworks_base-e30b53cec5eb6eaa5d24231feb3207b917c1baab.tar.gz frameworks_base-e30b53cec5eb6eaa5d24231feb3207b917c1baab.tar.bz2 | |
Enter RectangleMode when the clip region is a rectangle
ClipArea's region mode implementation store the region's boundary in
a rectangle, and if the region is that rectangle, set its region to
empty. This is a bug, since as long as the ClipArea is in region
mode it treats its region as determinitive. When the next clipping
operation comes in, it is tested against the empty region instead of
against the valid rect.
Discovered via Skia GM testing.
Change-Id: I3bbc4e81c8d68636061f830156e017e9b5c7e587
Diffstat (limited to 'libs/hwui/ClipArea.h')
| -rw-r--r-- | libs/hwui/ClipArea.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libs/hwui/ClipArea.h b/libs/hwui/ClipArea.h index 16e6df9..e284af0 100644 --- a/libs/hwui/ClipArea.h +++ b/libs/hwui/ClipArea.h @@ -144,7 +144,7 @@ private: float bottom, const mat4* transform, SkRegion::Op op); void ensureClipRegion(); - void setClipRectToRegionBounds(); + void onClipRegionUpdated(); bool clipRegionOp(float left, float top, float right, float bottom, SkRegion::Op op); |