diff options
author | Sangkyu Lee <sk82.lee@lge.com> | 2015-01-12 09:51:53 +0900 |
---|---|---|
committer | Sangkyu Lee <sk82.lee@lge.com> | 2015-01-12 13:10:52 +0900 |
commit | c3c58e015fa30a0ad87d4af2b95b7071baa8ffe4 (patch) | |
tree | 9d76978e72832d6f33357c39445aecf804ee4b21 /libs/hwui/PathCache.cpp | |
parent | 7f94b52fc7c66bc40702b46f59b3929c076cbbfb (diff) | |
download | frameworks_base-c3c58e015fa30a0ad87d4af2b95b7071baa8ffe4.zip frameworks_base-c3c58e015fa30a0ad87d4af2b95b7071baa8ffe4.tar.gz frameworks_base-c3c58e015fa30a0ad87d4af2b95b7071baa8ffe4.tar.bz2 |
Fix ANR caused by hwuiTask thread
If hwuiTask thread is exited while HWUI renders something,
some tasks can remain unfinished forever.
This can make ANR problem if RenderThread waits this kind of tasks.
According to the current implementation, hwuiTask threads are
exited when HWUI receives trimMemory() callback with level >= 20
and some applications such as SystemUI can receive trimMemory()
with level >= 20 even though they renders something yet.
(For instance, when RecentsActivity in SystemUI is finished,
HWUI receives trimMemory() callback with level >= 20
but SystemUI should still render the status bar and navigation bar.)
This patch prevents the tasks from remaining unfinished and
make the tasks executed immediately if they cannot be added
to their TaskProcessors.
Change-Id: I5bd26439aa5f183b1a7c1ce466362e27554b4d16
Diffstat (limited to 'libs/hwui/PathCache.cpp')
-rw-r--r-- | libs/hwui/PathCache.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/libs/hwui/PathCache.cpp b/libs/hwui/PathCache.cpp index a3d7019..302d1a9 100644 --- a/libs/hwui/PathCache.cpp +++ b/libs/hwui/PathCache.cpp @@ -493,7 +493,9 @@ void PathCache::precache(const SkPath* path, const SkPaint* paint) { if (mProcessor == NULL) { mProcessor = new PathProcessor(Caches::getInstance()); } - mProcessor->add(task); + if (!mProcessor->add(task)) { + mProcessor->process(task); + } } } |