summaryrefslogtreecommitdiffstats
path: root/libs/utils
diff options
context:
space:
mode:
authorMathias Agopian <mathias@google.com>2011-06-15 22:42:52 -0700
committerAndroid Git Automerger <android-git-automerger@android.com>2011-06-15 22:42:52 -0700
commit35e6d6867c63ad254e95325206aa7a927edd6797 (patch)
treef97feb4c06ceed98684b0431931c2eb6403d3999 /libs/utils
parent552bd670071b519d97124621a3c11dc98062c12b (diff)
parent0887b8c2e583e682cd2c1bc909cb3fdbec704004 (diff)
downloadframeworks_base-35e6d6867c63ad254e95325206aa7a927edd6797.zip
frameworks_base-35e6d6867c63ad254e95325206aa7a927edd6797.tar.gz
frameworks_base-35e6d6867c63ad254e95325206aa7a927edd6797.tar.bz2
am 0887b8c2: am 8e18668d: revert surfaceflinger leak fix as it uncovered a crasher on xoom (DO NOT MERGE)
* commit '0887b8c2e583e682cd2c1bc909cb3fdbec704004': revert surfaceflinger leak fix as it uncovered a crasher on xoom (DO NOT MERGE)
Diffstat (limited to 'libs/utils')
-rw-r--r--libs/utils/RefBase.cpp44
1 files changed, 9 insertions, 35 deletions
diff --git a/libs/utils/RefBase.cpp b/libs/utils/RefBase.cpp
index 8db2009..2034486 100644
--- a/libs/utils/RefBase.cpp
+++ b/libs/utils/RefBase.cpp
@@ -49,11 +49,6 @@ namespace android {
// ---------------------------------------------------------------------------
-RefBase::Destroyer::~Destroyer() {
-}
-
-// ---------------------------------------------------------------------------
-
class RefBase::weakref_impl : public RefBase::weakref_type
{
public:
@@ -61,7 +56,7 @@ public:
volatile int32_t mWeak;
RefBase* const mBase;
volatile int32_t mFlags;
- Destroyer* mDestroyer;
+
#if !DEBUG_REFS
@@ -70,7 +65,6 @@ public:
, mWeak(0)
, mBase(base)
, mFlags(0)
- , mDestroyer(0)
{
}
@@ -363,11 +357,7 @@ void RefBase::decStrong(const void* id) const
if (c == 1) {
const_cast<RefBase*>(this)->onLastStrongRef(id);
if ((refs->mFlags&OBJECT_LIFETIME_WEAK) != OBJECT_LIFETIME_WEAK) {
- if (refs->mDestroyer) {
- refs->mDestroyer->destroy(this);
- } else {
- delete this;
- }
+ delete this;
}
}
refs->decWeak(id);
@@ -400,9 +390,7 @@ int32_t RefBase::getStrongCount() const
return mRefs->mStrong;
}
-void RefBase::setDestroyer(RefBase::Destroyer* destroyer) {
- mRefs->mDestroyer = destroyer;
-}
+
RefBase* RefBase::weakref_type::refBase() const
{
@@ -426,28 +414,16 @@ void RefBase::weakref_type::decWeak(const void* id)
if (c != 1) return;
if ((impl->mFlags&OBJECT_LIFETIME_WEAK) != OBJECT_LIFETIME_WEAK) {
- if (impl->mStrong == INITIAL_STRONG_VALUE) {
- if (impl->mBase) {
- if (impl->mDestroyer) {
- impl->mDestroyer->destroy(impl->mBase);
- } else {
- delete impl->mBase;
- }
- }
- } else {
+ if (impl->mStrong == INITIAL_STRONG_VALUE)
+ delete impl->mBase;
+ else {
// LOGV("Freeing refs %p of old RefBase %p\n", this, impl->mBase);
delete impl;
}
} else {
impl->mBase->onLastWeakRef(id);
if ((impl->mFlags&OBJECT_LIFETIME_FOREVER) != OBJECT_LIFETIME_FOREVER) {
- if (impl->mBase) {
- if (impl->mDestroyer) {
- impl->mDestroyer->destroy(impl->mBase);
- } else {
- delete impl->mBase;
- }
- }
+ delete impl->mBase;
}
}
}
@@ -569,10 +545,8 @@ RefBase::RefBase()
RefBase::~RefBase()
{
- if ((mRefs->mFlags & OBJECT_LIFETIME_WEAK) == OBJECT_LIFETIME_WEAK) {
- if (mRefs->mWeak == 0) {
- delete mRefs;
- }
+ if (mRefs->mWeak == 0) {
+ delete mRefs;
}
}