diff options
| author | Glenn Kasten <gkasten@google.com> | 2011-07-14 16:16:54 -0700 |
|---|---|---|
| committer | Glenn Kasten <gkasten@google.com> | 2011-07-14 16:16:54 -0700 |
| commit | 2c751a8416b5941b94171bab685505ae553ac16c (patch) | |
| tree | a5c40801a19651683645fefecda0c517ad4683b6 /media | |
| parent | cadaa3a9839d152cdbdb8c3d5070d315910da5dd (diff) | |
| download | frameworks_base-2c751a8416b5941b94171bab685505ae553ac16c.zip frameworks_base-2c751a8416b5941b94171bab685505ae553ac16c.tar.gz frameworks_base-2c751a8416b5941b94171bab685505ae553ac16c.tar.bz2 | |
Bug 5031179 possible fix for assert in join
Change-Id: Id3a24c152579b8fdcfb9d66a11aa11579406a7ec
Diffstat (limited to 'media')
| -rw-r--r-- | media/libstagefright/omx/OMX.cpp | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/media/libstagefright/omx/OMX.cpp b/media/libstagefright/omx/OMX.cpp index 25f30d6..bc24dbb 100644 --- a/media/libstagefright/omx/OMX.cpp +++ b/media/libstagefright/omx/OMX.cpp @@ -96,9 +96,14 @@ OMX::CallbackDispatcher::~CallbackDispatcher() { mQueueChanged.signal(); } - // Don't call join on myself + // A join on self can happen if the last ref to CallbackDispatcher + // is released within the CallbackDispatcherThread loop status_t status = mThread->join(); - CHECK(status == NO_ERROR); + if (status != WOULD_BLOCK) { + // Other than join to self, the only other error return codes are + // whatever readyToRun() returns, and we don't override that + CHECK_EQ(status, NO_ERROR); + } } void OMX::CallbackDispatcher::post(const omx_message &msg) { |