diff options
author | Gloria Wang <gwang@google.com> | 2010-02-22 16:08:28 -0800 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2010-02-22 16:08:28 -0800 |
commit | 582ae172a4e9784f377c9935b47160fba1764142 (patch) | |
tree | d2eecdf218e1314594f4bfc890d0ae9074f88b6f /media | |
parent | ab9985ed4c02ef70d4a48bf3bbeedc12d14928f3 (diff) | |
parent | 196863d27407e23c69debdd061df58ce8fe76c20 (diff) | |
download | frameworks_base-582ae172a4e9784f377c9935b47160fba1764142.zip frameworks_base-582ae172a4e9784f377c9935b47160fba1764142.tar.gz frameworks_base-582ae172a4e9784f377c9935b47160fba1764142.tar.bz2 |
Merge "Fix for the safty check. It checks that nFir21 + jNpoints <= BUF_SIZE, but when it calls GetByteArrayRegion, it multiplies it by 2 which defeats the "// safety first" check at the beginning."
Diffstat (limited to 'media')
-rw-r--r-- | media/jni/android_media_ResampleInputStream.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/media/jni/android_media_ResampleInputStream.cpp b/media/jni/android_media_ResampleInputStream.cpp index f248557..d965d9a 100644 --- a/media/jni/android_media_ResampleInputStream.cpp +++ b/media/jni/android_media_ResampleInputStream.cpp @@ -92,7 +92,7 @@ static void android_media_ResampleInputStream_fir21(JNIEnv *env, jclass clazz, jint jNpoints) { // safety first! - if (nFir21 + jNpoints > BUF_SIZE) { + if (nFir21 + jNpoints * 2 > BUF_SIZE) { throwException(env, "java/lang/IllegalArgumentException", "FIR+data too long %d", nFir21 + jNpoints); return; |