summaryrefslogtreecommitdiffstats
path: root/media
diff options
context:
space:
mode:
authorAndroid (Google) Code Review <android-gerrit@google.com>2009-10-26 21:00:46 -0400
committerAndroid (Google) Code Review <android-gerrit@google.com>2009-10-26 21:00:46 -0400
commite8543418783f8f8f9a6bafdaa1dd6289661eac85 (patch)
tree77b838660cc6262cd69bc4dec5c59ca0b2287911 /media
parentb81df8e3a2f72546508fcdf92adc39cfa2985c56 (diff)
parent7c0d20a753a930507bec09d7f89da83acc86d0da (diff)
downloadframeworks_base-e8543418783f8f8f9a6bafdaa1dd6289661eac85.zip
frameworks_base-e8543418783f8f8f9a6bafdaa1dd6289661eac85.tar.gz
frameworks_base-e8543418783f8f8f9a6bafdaa1dd6289661eac85.tar.bz2
Merge change I7c0d20a7 into eclair
* changes: Run the metadataretriever at background priority. Bug 2187133.
Diffstat (limited to 'media')
-rw-r--r--media/libmediaplayerservice/MetadataRetrieverClient.cpp27
-rw-r--r--media/libmediaplayerservice/MetadataRetrieverClient.h10
2 files changed, 37 insertions, 0 deletions
diff --git a/media/libmediaplayerservice/MetadataRetrieverClient.cpp b/media/libmediaplayerservice/MetadataRetrieverClient.cpp
index ddd4e24..8eabe5d 100644
--- a/media/libmediaplayerservice/MetadataRetrieverClient.cpp
+++ b/media/libmediaplayerservice/MetadataRetrieverClient.cpp
@@ -21,6 +21,7 @@
#include <sys/types.h>
#include <sys/stat.h>
+#include <sys/resource.h>
#include <dirent.h>
#include <unistd.h>
@@ -38,6 +39,18 @@
#include "MidiMetadataRetriever.h"
#include "MetadataRetrieverClient.h"
+/* desktop Linux needs a little help with gettid() */
+#if defined(HAVE_GETTID) && !defined(HAVE_ANDROID_OS)
+#define __KERNEL__
+# include <linux/unistd.h>
+#ifdef _syscall0
+_syscall0(pid_t,gettid)
+#else
+pid_t gettid() { return syscall(__NR_gettid);}
+#endif
+#undef __KERNEL__
+#endif
+
namespace android {
extern player_type getPlayerType(const char* url);
@@ -212,6 +225,7 @@ sp<IMemory> MetadataRetrieverClient::captureFrame()
{
LOGV("captureFrame");
Mutex::Autolock lock(mLock);
+ Priority priority(ANDROID_PRIORITY_BACKGROUND);
mThumbnail.clear();
mThumbnailDealer.clear();
if (mRetriever == NULL) {
@@ -253,6 +267,7 @@ sp<IMemory> MetadataRetrieverClient::extractAlbumArt()
{
LOGV("extractAlbumArt");
Mutex::Autolock lock(mLock);
+ Priority priority(ANDROID_PRIORITY_BACKGROUND);
mAlbumArt.clear();
mAlbumArtDealer.clear();
if (mRetriever == NULL) {
@@ -294,7 +309,19 @@ const char* MetadataRetrieverClient::extractMetadata(int keyCode)
LOGE("retriever is not initialized");
return NULL;
}
+ Priority priority(ANDROID_PRIORITY_BACKGROUND);
return mRetriever->extractMetadata(keyCode);
}
+MetadataRetrieverClient::Priority::Priority(int newPriority)
+{
+ mOldPriority = getpriority(PRIO_PROCESS, 0);
+ setpriority(PRIO_PROCESS, 0, newPriority);
+}
+
+MetadataRetrieverClient::Priority::~Priority()
+{
+ setpriority(PRIO_PROCESS, 0, mOldPriority);
+}
+
}; // namespace android
diff --git a/media/libmediaplayerservice/MetadataRetrieverClient.h b/media/libmediaplayerservice/MetadataRetrieverClient.h
index 8cb8ad1..852d734 100644
--- a/media/libmediaplayerservice/MetadataRetrieverClient.h
+++ b/media/libmediaplayerservice/MetadataRetrieverClient.h
@@ -54,6 +54,16 @@ public:
private:
friend class MediaPlayerService;
+ class Priority
+ {
+ public:
+ Priority(int newPriority);
+ ~Priority();
+ private:
+ Priority();
+ int mOldPriority;
+ };
+
explicit MetadataRetrieverClient(pid_t pid);
virtual ~MetadataRetrieverClient();