summaryrefslogtreecommitdiffstats
path: root/packages/DocumentsUI/src
diff options
context:
space:
mode:
authorJeff Sharkey <jsharkey@android.com>2015-07-15 09:13:14 -0700
committerJeff Sharkey <jsharkey@android.com>2015-07-15 09:13:14 -0700
commit04ec6f4f092f1c2d56ef6213019ce4b9068b8a0a (patch)
tree1ba251f0385e667f288f1318aa524f3e151354ed /packages/DocumentsUI/src
parent983294596e65a0226aa69e42bda9db322727fee5 (diff)
downloadframeworks_base-04ec6f4f092f1c2d56ef6213019ce4b9068b8a0a.zip
frameworks_base-04ec6f4f092f1c2d56ef6213019ce4b9068b8a0a.tar.gz
frameworks_base-04ec6f4f092f1c2d56ef6213019ce4b9068b8a0a.tar.bz2
Only send EXTRA_STACK for private intent.
Since it's a private Parcelable class, we can't send it to other third-party apps, since they won't know how to unpack it. Bug: 22255387 Change-Id: Ie2ea6cf72b733bd122eb3581a5df295cec608425
Diffstat (limited to 'packages/DocumentsUI/src')
-rw-r--r--packages/DocumentsUI/src/com/android/documentsui/DocumentsActivity.java9
1 files changed, 5 insertions, 4 deletions
diff --git a/packages/DocumentsUI/src/com/android/documentsui/DocumentsActivity.java b/packages/DocumentsUI/src/com/android/documentsui/DocumentsActivity.java
index c541bca..a57bcc6 100644
--- a/packages/DocumentsUI/src/com/android/documentsui/DocumentsActivity.java
+++ b/packages/DocumentsUI/src/com/android/documentsui/DocumentsActivity.java
@@ -720,14 +720,15 @@ public class DocumentsActivity extends BaseActivity {
if (mState.action == ACTION_GET_CONTENT) {
intent.addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION);
- } else if (mState.action == ACTION_OPEN_TREE ||
- mState.action == ACTION_OPEN_COPY_DESTINATION) {
+ } else if (mState.action == ACTION_OPEN_TREE) {
intent.addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION
| Intent.FLAG_GRANT_WRITE_URI_PERMISSION
| Intent.FLAG_GRANT_PERSISTABLE_URI_PERMISSION
| Intent.FLAG_GRANT_PREFIX_URI_PERMISSION);
- // TODO: Move passing the stack to the separate ACTION_COPY action once it's implemented.
- intent.putExtra(CopyService.EXTRA_STACK, (Parcelable)mState.stack);
+ } else if (mState.action == ACTION_OPEN_COPY_DESTINATION) {
+ // Picking a copy destination is only used internally by us, so we
+ // don't need to extend permissions to the caller.
+ intent.putExtra(CopyService.EXTRA_STACK, (Parcelable) mState.stack);
} else {
intent.addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION
| Intent.FLAG_GRANT_WRITE_URI_PERMISSION