summaryrefslogtreecommitdiffstats
path: root/packages/SystemUI/src/com
diff options
context:
space:
mode:
authorSelim Cinek <cinek@google.com>2015-09-01 17:07:38 -0700
committerSelim Cinek <cinek@google.com>2015-09-02 00:10:45 +0000
commit0b4aeab281d0bd18e67f245eeccbbc468f3065f1 (patch)
treec30d8e929165290ae5d544dcfc14feb7a55f7f26 /packages/SystemUI/src/com
parentcbacd4f0cee10b63adf6e2d482e7b4f62c0104a0 (diff)
downloadframeworks_base-0b4aeab281d0bd18e67f245eeccbbc468f3065f1.zip
frameworks_base-0b4aeab281d0bd18e67f245eeccbbc468f3065f1.tar.gz
frameworks_base-0b4aeab281d0bd18e67f245eeccbbc468f3065f1.tar.bz2
Fixed a crash in the notification group manager
When 2 notifications were posted as the summary of the same group, then the system would eventually crash. Bug: 23676310 Change-Id: Ia8f95e624f3f43d1b55169dd8102e3c89427dc76
Diffstat (limited to 'packages/SystemUI/src/com')
-rw-r--r--packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationGroupManager.java7
1 files changed, 7 insertions, 0 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationGroupManager.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationGroupManager.java
index 950b162..310625e 100644
--- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationGroupManager.java
+++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationGroupManager.java
@@ -78,6 +78,13 @@ public class NotificationGroupManager {
Notification notif = sbn.getNotification();
String groupKey = sbn.getGroupKey();
final NotificationGroup group = mGroupMap.get(groupKey);
+ if (group == null) {
+ // When an app posts 2 different notifications as summary of the same group, then a
+ // cancellation of the first notification removes this group.
+ // This situation is not supported and we will not allow such notifications anymore in
+ // the close future. See b/23676310 for reference.
+ return;
+ }
if (notif.isGroupSummary()) {
group.summary = null;
} else {