summaryrefslogtreecommitdiffstats
path: root/rs
diff options
context:
space:
mode:
authorJason Sams <jsams@google.com>2015-05-05 18:00:34 -0700
committerJason Sams <jsams@google.com>2015-05-05 18:00:34 -0700
commitd1516dffa8d676fcad092d9736163829e6d0fdce (patch)
tree14fd6780659583b86cbc27ce8299768bfff0b2c8 /rs
parente74007ded3a34d6aaf7dc4fe7f2c18b04b47de3b (diff)
downloadframeworks_base-d1516dffa8d676fcad092d9736163829e6d0fdce.zip
frameworks_base-d1516dffa8d676fcad092d9736163829e6d0fdce.tar.gz
frameworks_base-d1516dffa8d676fcad092d9736163829e6d0fdce.tar.bz2
Fix Allocation-less launches
Cherry-pick fix from AOSP. Error check for kernel launch was generating a false positive. bug 20690242 Change-Id: Ic4c6644072a11aab9a273070be5734519136f685
Diffstat (limited to 'rs')
-rw-r--r--rs/java/android/renderscript/Script.java4
-rw-r--r--rs/jni/android_renderscript_RenderScript.cpp4
2 files changed, 4 insertions, 4 deletions
diff --git a/rs/java/android/renderscript/Script.java b/rs/java/android/renderscript/Script.java
index 6a1efee..7cd6d09 100644
--- a/rs/java/android/renderscript/Script.java
+++ b/rs/java/android/renderscript/Script.java
@@ -182,9 +182,9 @@ public class Script extends BaseObj {
mRS.validateObject(ain);
mRS.validateObject(aout);
- if (ain == null && aout == null) {
+ if (ain == null && aout == null && sc == null) {
throw new RSIllegalArgumentException(
- "At least one of ain or aout is required to be non-null.");
+ "At least one of input allocation, output allocation, or LaunchOptions is required to be non-null.");
}
long[] in_ids = null;
diff --git a/rs/jni/android_renderscript_RenderScript.cpp b/rs/jni/android_renderscript_RenderScript.cpp
index 80d6515..58d0fce 100644
--- a/rs/jni/android_renderscript_RenderScript.cpp
+++ b/rs/jni/android_renderscript_RenderScript.cpp
@@ -14,7 +14,7 @@
* limitations under the License.
*/
-#define LOG_TAG "libRS_jni"
+#define LOG_TAG "RenderScript_jni"
#include <stdlib.h>
#include <stdio.h>
@@ -1857,7 +1857,7 @@ nScriptForEach(JNIEnv *_env, jobject _this, jlong con, jlong script, jint slot,
jintArray limits)
{
if (kLogApi) {
- ALOGD("nScriptForEach, con(%p), s(%p), slot(%i)", (RsContext)con, (void *)script, slot);
+ ALOGD("nScriptForEach, con(%p), s(%p), slot(%i) ains(%p) aout(%lli)", (RsContext)con, (void *)script, slot, ains, aout);
}
jint in_len = 0;