summaryrefslogtreecommitdiffstats
path: root/services/appwidget
diff options
context:
space:
mode:
authorSvet Ganov <svetoslavganov@google.com>2014-08-21 08:31:55 -0700
committerSvetoslav Ganov <svetoslavganov@google.com>2014-08-21 15:47:08 +0000
commit3de01b2e3474ac2eaccbcf72b6693bb19d254824 (patch)
tree7143e9241725f79a1b26ca1e98b224b40f9d13e4 /services/appwidget
parente4be1bf2bed48afd234ea1f2558c60beffe3fa18 (diff)
downloadframeworks_base-3de01b2e3474ac2eaccbcf72b6693bb19d254824.zip
frameworks_base-3de01b2e3474ac2eaccbcf72b6693bb19d254824.tar.gz
frameworks_base-3de01b2e3474ac2eaccbcf72b6693bb19d254824.tar.bz2
Fix a regression in partially updading app widgets.
App widgets can be partially updated where only the actions delta is delivered to the client. There was a regression where instead of sending the delta, the merged remote views were sent. This was problematic because certain actions are ignored when merging to avoid clutter (specifically showNext and showPrevious), hence these actions never reached the client. bug:16844814 Change-Id: I88ab58e610cda24154985165e6d6d93a1baa9c79
Diffstat (limited to 'services/appwidget')
-rw-r--r--services/appwidget/java/com/android/server/appwidget/AppWidgetServiceImpl.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/services/appwidget/java/com/android/server/appwidget/AppWidgetServiceImpl.java b/services/appwidget/java/com/android/server/appwidget/AppWidgetServiceImpl.java
index c6aa30b..f1e99fd 100644
--- a/services/appwidget/java/com/android/server/appwidget/AppWidgetServiceImpl.java
+++ b/services/appwidget/java/com/android/server/appwidget/AppWidgetServiceImpl.java
@@ -1539,7 +1539,7 @@ class AppWidgetServiceImpl extends IAppWidgetService.Stub implements WidgetBacku
widget.views = views;
}
- scheduleNotifyUpdateAppWidgetLocked(widget);
+ scheduleNotifyUpdateAppWidgetLocked(widget, views);
}
}
@@ -1611,7 +1611,7 @@ class AppWidgetServiceImpl extends IAppWidgetService.Stub implements WidgetBacku
}
}
- private void scheduleNotifyUpdateAppWidgetLocked(Widget widget) {
+ private void scheduleNotifyUpdateAppWidgetLocked(Widget widget, RemoteViews updateViews) {
if (widget == null || widget.provider == null || widget.provider.zombie
|| widget.host.callbacks == null || widget.host.zombie) {
return;
@@ -1620,7 +1620,7 @@ class AppWidgetServiceImpl extends IAppWidgetService.Stub implements WidgetBacku
SomeArgs args = SomeArgs.obtain();
args.arg1 = widget.host;
args.arg2 = widget.host.callbacks;
- args.arg3 = widget.views;
+ args.arg3 = updateViews;
args.argi1 = widget.appWidgetId;
mCallbackHandler.obtainMessage(