diff options
author | Glenn Kasten <gkasten@google.com> | 2012-03-09 07:19:17 -0800 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2012-03-09 07:19:17 -0800 |
commit | 1e8b118a409cbd11e295147b7ceaae3cff9e0920 (patch) | |
tree | 79da78a0c4d40435231496e8580334ffecfd6c9f /services/audioflinger | |
parent | a64890a02e5561d73da57695dcfc6b35ca05c321 (diff) | |
parent | fcf2ac041e18fd5cd97997bfd2bce62e9a24fe19 (diff) | |
download | frameworks_base-1e8b118a409cbd11e295147b7ceaae3cff9e0920.zip frameworks_base-1e8b118a409cbd11e295147b7ceaae3cff9e0920.tar.gz frameworks_base-1e8b118a409cbd11e295147b7ceaae3cff9e0920.tar.bz2 |
Merge "AudioPolicyService InputDesc minor cleanup"
Diffstat (limited to 'services/audioflinger')
-rw-r--r-- | services/audioflinger/AudioPolicyService.cpp | 8 | ||||
-rw-r--r-- | services/audioflinger/AudioPolicyService.h | 8 |
2 files changed, 7 insertions, 9 deletions
diff --git a/services/audioflinger/AudioPolicyService.cpp b/services/audioflinger/AudioPolicyService.cpp index 62768bf..d57326b 100644 --- a/services/audioflinger/AudioPolicyService.cpp +++ b/services/audioflinger/AudioPolicyService.cpp @@ -298,8 +298,7 @@ audio_io_handle_t AudioPolicyService::getInput(audio_source_t inputSource, ssize_t idx = mInputs.indexOfKey(input); InputDesc *inputDesc; if (idx < 0) { - inputDesc = new InputDesc(); - inputDesc->mSessionId = audioSession; + inputDesc = new InputDesc(audioSession); mInputs.add(input, inputDesc); } else { inputDesc = mInputs.valueAt(idx); @@ -358,7 +357,6 @@ void AudioPolicyService::releaseInput(audio_io_handle_t input) } InputDesc *inputDesc = mInputs.valueAt(index); setPreProcessorEnabled(inputDesc, false); - inputDesc->mEffects.clear(); delete inputDesc; mInputs.removeItemsAt(index); } @@ -602,9 +600,9 @@ status_t AudioPolicyService::dumpPermissionDenial(int fd) return NO_ERROR; } -void AudioPolicyService::setPreProcessorEnabled(InputDesc *inputDesc, bool enabled) +void AudioPolicyService::setPreProcessorEnabled(const InputDesc *inputDesc, bool enabled) { - Vector<sp<AudioEffect> > fxVector = inputDesc->mEffects; + const Vector<sp<AudioEffect> > &fxVector = inputDesc->mEffects; for (size_t i = 0; i < fxVector.size(); i++) { fxVector.itemAt(i)->setEnabled(enabled); } diff --git a/services/audioflinger/AudioPolicyService.h b/services/audioflinger/AudioPolicyService.h index e41d51e..7119b90 100644 --- a/services/audioflinger/AudioPolicyService.h +++ b/services/audioflinger/AudioPolicyService.h @@ -279,15 +279,15 @@ private: class InputDesc { public: - InputDesc() {} - virtual ~InputDesc() {} - int mSessionId; + InputDesc(int session) : mSessionId(session) {} + /*virtual*/ ~InputDesc() {} + const int mSessionId; Vector< sp<AudioEffect> >mEffects; }; static const char * const kInputSourceNames[AUDIO_SOURCE_CNT -1]; - void setPreProcessorEnabled(InputDesc *inputDesc, bool enabled); + void setPreProcessorEnabled(const InputDesc *inputDesc, bool enabled); status_t loadPreProcessorConfig(const char *path); status_t loadEffects(cnode *root, Vector <EffectDesc *>& effects); EffectDesc *loadEffect(cnode *root); |