summaryrefslogtreecommitdiffstats
path: root/services/audioflinger
diff options
context:
space:
mode:
authorGlenn Kasten <gkasten@google.com>2012-03-06 15:52:35 -0800
committerGlenn Kasten <gkasten@google.com>2012-03-07 10:40:43 -0800
commite012783db87815fab07c91b8f1faff3e2d7dbd3c (patch)
tree95c6946048a9e5671c3df0c350f1623d349bc911 /services/audioflinger
parent761415bd7f5611812336a3d39b3f6baac22a1b88 (diff)
downloadframeworks_base-e012783db87815fab07c91b8f1faff3e2d7dbd3c.zip
frameworks_base-e012783db87815fab07c91b8f1faff3e2d7dbd3c.tar.gz
frameworks_base-e012783db87815fab07c91b8f1faff3e2d7dbd3c.tar.bz2
Make applyVolume private to DirectOutputThread
Change-Id: I7ca4a59505857cbd106b6f274c66e9580dead271
Diffstat (limited to 'services/audioflinger')
-rw-r--r--services/audioflinger/AudioFlinger.cpp9
-rw-r--r--services/audioflinger/AudioFlinger.h4
2 files changed, 4 insertions, 9 deletions
diff --git a/services/audioflinger/AudioFlinger.cpp b/services/audioflinger/AudioFlinger.cpp
index 8deb2fe..fe068af 100644
--- a/services/audioflinger/AudioFlinger.cpp
+++ b/services/audioflinger/AudioFlinger.cpp
@@ -2166,14 +2166,6 @@ if (mType == DIRECT) {
// only process effects if we're going to write
if (sleepTime == 0) {
-
- if (mixerStatus == MIXER_TRACKS_READY) {
-
- // Non-trivial for DIRECT only
- applyVolume();
-
- }
-
for (size_t i = 0; i < effectChains.size(); i ++) {
effectChains[i]->process_l();
}
@@ -2999,6 +2991,7 @@ void AudioFlinger::DirectOutputThread::threadLoop_mix()
}
sleepTime = 0;
standbyTime = systemTime() + standbyDelay;
+ applyVolume();
}
void AudioFlinger::DirectOutputThread::threadLoop_sleepTime()
diff --git a/services/audioflinger/AudioFlinger.h b/services/audioflinger/AudioFlinger.h
index edf083f..621ff8f 100644
--- a/services/audioflinger/AudioFlinger.h
+++ b/services/audioflinger/AudioFlinger.h
@@ -1004,7 +1004,6 @@ public:
virtual mixer_state prepareTracks_l(Vector< sp<Track> > *tracksToRemove);
virtual void threadLoop_mix();
virtual void threadLoop_sleepTime();
- virtual void applyVolume();
// volumes last sent to audio HAL with stream->set_volume()
// FIXME use standard representation and names
@@ -1018,6 +1017,9 @@ public:
bool rampVolume;
uint16_t leftVol;
uint16_t rightVol;
+
+private:
+ void applyVolume(); // FIXME inline into threadLoop_mix()
};
class DuplicatingThread : public MixerThread {